-
Notifications
You must be signed in to change notification settings - Fork 23
feat(dashboard): unify visual editor UI with live docs for section names and subtitles #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sbawabe
merged 12 commits into
app
from
devin/1761768444-unify-visual-editor-section-name-subtitle
Oct 30, 2025
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bfbc141
feat(dashboard): unify visual editor UI with live docs for section na…
devin-ai-integration[bot] 20b166d
refactor: move FernBreadcrumbs to shared components package
devin-ai-integration[bot] 595594d
fix: use FernNavigation.utils.createBreadcrumb for visual editor brea…
devin-ai-integration[bot] 4ea0c9c
fix: show breadcrumbs for all pages with parents, not just guide layout
devin-ai-integration[bot] 09bc94f
fix: add breadcrumb CSS and wrap header elements in mx-5 container
devin-ai-integration[bot] 47b0f04
fix: use EditorAwareBreadcrumbs to generate proper editor URLs
devin-ai-integration[bot] d157854
Apply suggestion from @sbawabe
sbawabe 8948e36
Apply suggestion from @sbawabe
sbawabe 18c836e
chore: remove duplicate FernBreadcrumbs.scss and add not-prose class
devin-ai-integration[bot] 775ef36
Merge branch 'devin/1761768444-unify-visual-editor-section-name-subti…
devin-ai-integration[bot] 6a851c0
Apply suggestion from @sbawabe
sbawabe d293df6
refactor(dashboard): replace EditorAwareBreadcrumbs with shared FernB…
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
71 changes: 68 additions & 3 deletions
71
...rd/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/PageContents.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| @layer components { | ||
| .fern-breadcrumb { | ||
| @apply inline-flex h-fit max-w-full flex-wrap items-baseline font-medium; | ||
|
|
||
| .fern-breadcrumb-item { | ||
| @apply text-(color:--accent-a11) min-w-0 shrink text-sm; | ||
| } | ||
|
|
||
| .fern-breadcrumb-arrow { | ||
| @apply text-(color:--grayscale-a9) mx-0.5 size-4 self-center; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devin is
EditorAwareBreadcrumbsnecessary? we have our EditorRouteInterceptor logic anyways would think this is unnecessary and would be caught by our interceptor.