-
Notifications
You must be signed in to change notification settings - Fork 3
Fix race conditions in mock methods and mock properties #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race conditions in mock methods and mock properties #122
Conversation
ad97739
to
fe19537
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 69.24% 69.65% +0.40%
==========================================
Files 73 73
Lines 4585 4811 +226
==========================================
+ Hits 3175 3351 +176
- Misses 1410 1460 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In regards to the Codecov Report, I didn't add any new tests in this PR. It's already a very big PR, so I decided to only update existing tests. I will add new tests for all the mock property accessors in a separate PR later this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things I think we can improve but otherwise looks good ✅
📝 Summary
🛠️ Type of Change
🧪 How Has This Been Tested?
🔗 Related PRs or Issues
✅ Checklist
SwiftFormat