parallel tests and faster runners #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ok, so... faster. But we don't have a 4x arm64 runner. |
Stebalien
force-pushed
the
steb/faster-ci
branch
from
38ce882 to
cadfe50
Compare
Member
Author
BigLep
approved these changes
Nov 20, 2024
Member
BigLep
left a comment
BigLep
left a comment
There was a problem hiding this comment.
Looks good to me?
I assume we're good to no longer have
--test-threads 1 and -p 1
?
Do we know what changed to allow us to not need this anymore (great that we don't). (No need to slow down to explain to me - I was just curious).
Member
Author
Looking through history, that was added way back in 2019 (possibly before, it could have been ported from rust-fil-proofs-ffi). See 3de4c15. I'm guessing we may have been testing with GPUs at that point and couldn't use the same GPU from multiple threads? I'm not sure, but it doesn't seem necessary now and removing it makes everything faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #498