-
Notifications
You must be signed in to change notification settings - Fork 136
ci: create release uploader workflow #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added note about manually running the Upload Release Assets workflow if asset uploading fails.
@galargh : I updated RELEASE.md: cae19d6 It seems like this improvement idea would have been useful here: "Add a check to the Releaser workflow to ensure that the created/published release contains the expected assets. If it does not, create them and run the publish-release.sh script to upload the missing assets." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine with the name & description fixed
Yes, I like it! Let's do it as a separate item though as it will require adding a check for whether the release assets are already there which is new. |
This will create a new workflow
Upload Release Assets
which can be used to do emergency release assets uploads when something goes wrong.I tested it by triggering https://github.com/filecoin-project/filecoin-ffi/actions/runs/17773290672 on push. It is failing because the action I'm adding here is not available in the tag of the release that we were uploading assets to. It's just a false negative.