Skip to content

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Sep 16, 2025

This will create a new workflow Upload Release Assets which can be used to do emergency release assets uploads when something goes wrong.

I tested it by triggering https://github.com/filecoin-project/filecoin-ffi/actions/runs/17773290672 on push. It is failing because the action I'm adding here is not available in the tag of the release that we were uploading assets to. It's just a false negative.

@galargh galargh requested a review from BigLep September 16, 2025 17:22
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 16, 2025
Added note about manually running the Upload Release Assets workflow if asset uploading fails.
@BigLep
Copy link
Member

BigLep commented Sep 16, 2025

@galargh : I updated RELEASE.md: cae19d6

It seems like this improvement idea would have been useful here: "Add a check to the Releaser workflow to ensure that the created/published release contains the expected assets. If it does not, create them and run the publish-release.sh script to upload the missing assets."

@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Sep 16, 2025
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with the name & description fixed

@galargh
Copy link
Contributor Author

galargh commented Sep 18, 2025

It seems like this improvement idea would have been useful here: "Add a check to the Releaser workflow to ensure that the created/published release contains the expected assets. If it does not, create them and run the publish-release.sh script to upload the missing assets."

Yes, I like it! Let's do it as a separate item though as it will require adding a check for whether the release assets are already there which is new.

@BigLep
Copy link
Member

BigLep commented Sep 18, 2025

Yes, I like it! Let's do it as a separate item though as it will require adding a check for whether the release assets are already there which is new.

Issue created (#543 ) and I assigned it to @copilot to see how it does... Feel free to take over.

I'll squash and merge.

@BigLep BigLep merged commit 46e0cc0 into master Sep 18, 2025
5 checks passed
@BigLep BigLep deleted the upload-assets branch September 18, 2025 19:52
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

3 participants