feat: implement encoding.TextMarshaler/Unmarshaler for EthUint64 #13071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sztandera <[email protected]>
Stebalien
requested changes
Apr 25, 2025
| *e = EthUint64(eint) | ||
| return nil | ||
| // if string literal, remove quotes | ||
| if b[0] == '"' && b[len(b)-1] == '"' { |
There was a problem hiding this comment.
Use json.Unmarshal. This won't handle:
- Strings < 2 bytes.
- JSON escape sequences.
Etc.
There was a problem hiding this comment.
100% missed the slice lengts, will do
|
@Kubuxu : I'm marking this as draft until feedback is incorporated. Then mark it ready for review so it's clear that others should look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.