[WIP] Upgrade golangci-lint to v2 #13280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure I love all the additional exclusions, we were trying to drive that number downward, might be good for someone here to spend some time looking through these and seeing what we can knock out with simple changes |
Agreed! I just wanted to establish a baseline with the new version. I'd be happy to look through which of the exclusions can be easily fixed. |
|
Closing this for now, we'll revisit this again when we have time to address the linting issues that would have to be fixed with this upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#13276
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: