Skip to content

fix(cli): improve error handling for disabled payment channels #13350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+49 −41
Open

fix(cli): improve error handling for disabled payment channels #13350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe92fd7
fix(cli): improve error handling for disabled payment channels in inf…
rjan90 Sep 19, 2025
3d6b865
refactor: use constant for payment channel error message
rjan90 Sep 23, 2025
37f7e5e
refactor: use RPC-traversable error for disabled payment channels
rjan90 Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ func infoCmdAct(cctx *cli.Context) error {
chs, err := fullapi.PaychList(ctx)
if err != nil {
// Check if the error is because payment channel manager is disabled
if errors.Is(err, paych.ErrPaymentChannelDisabled) {
// Use both errors.Is and string comparison for robustness
if errors.Is(err, paych.ErrPaymentChannelDisabled) ||
strings.Contains(err.Error(), "payment channels disabled") {
fmt.Printf("Payment Channels: disabled (EnablePaymentChannelManager is set to false)\n")
} else {
return err
Expand Down
2 changes: 1 addition & 1 deletion node/impl/paych/paych.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func (a *PaychImpl) PaychVoucherSubmit(ctx context.Context, ch address.Address,

// ErrPaymentChannelDisabled is returned when payment channel operations are attempted
// but the payment channel manager is disabled in the configuration.
var ErrPaymentChannelDisabled = xerrors.New("payment channel manager is disabled (EnablePaymentChannelManager is set to false)")
var ErrPaymentChannelDisabled = xerrors.New("payment channels disabled (EnablePaymentChannelManager=false)")

// DisabledPaych is a stub implementation of the PaychAPI interface that returns errors for all
// methods. It is used when the payment channel manager is disabled (e.g., when
Expand Down
Loading