-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix: Added conditional checking for virtual network path #17664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix: Added conditional checking for virtual network path #17664
Conversation
- RaiDrive seems to use a custom UNC path with the format of \\RaiDrive-{user}\{drive-custom-name}
// Skip authentication for RaiDrive virtual shares | ||
// RaiDrive creates virtual UNC paths that don't work with Windows networking APIs | ||
// Format is \\RaiDrive-{user}\{drive-custom-name}\ | ||
if (path.StartsWith(@"\\RaiDrive-", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create a constant for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code to use a string array constant for a list of virtual drive providers
Could this also apply to #17636 based on the site it's a separate program that adds a virtual network drive too |
- Added constant array of virtual disk providers
I had a look at #17636 and it seems to have a similar issue. When testing:
Another potentially related issue is #17521
|
I have updated the code to maintain a list of providers that seems to be using a virtual network drive. I'm not sure if we want to include the checks for both Cryptomator and Egnyte in this PR. |
Resolved / Related Issues
Steps used to test these changes
RaiDrive SFTP paths follow the format \RaiDrive-{username}{drive-custom-name}\
remoteName with either ERROR_BAD_NET_NAME or ERROR_NO_NET_OR_BAD_PATH
After applying the fix, successfully access RaiDrive SFTP drives through Files
application without errors
Checked with SSHFS to test behavior.