Skip to content

Conversation

@aanderse
Copy link
Contributor

citing https://skarnet.org/software/s6/notifywhenup.html

  • When your daemon is ready, write a newline to this file descriptor.
    • If you like, you may write other data before the newline, just in case it is printed to the terminal. It is not necessary, and it is best to keep that data short. If the line is read by s6-supervise, it will be entirely ignored; only the newline is important.

while testing out eudev support for s6 style readiness notifications i found out that finit is a bit too strict in its implementation

this patch relaxes finit check so it better implements the spec

Copy link
Collaborator

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, really appreciate someone else testing out the s6 style notifications!

Gave an inline suggestion for improvement.

@troglobit troglobit merged commit 1f47718 into finit-project:master Mar 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants