Skip to content

ppl pp #7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wu-hui wants to merge 170 commits into
base: main
Choose a base branch
from
Open

ppl pp #7590

wu-hui wants to merge 170 commits into from

Conversation

@wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Dec 9, 2025

No description provided.

@tom-andersen
Proto changes
fe05087
@tom-andersen
Copyright
159cb37
@tom-andersen
Expressions
282409a
@tom-andersen
Test
7f95bb5
@tom-andersen
Stage
2ec848d
@tom-andersen
Pipeline
16bb38c
@tom-andersen
Merge remote-tracking branch 'origin/main' into tomandersen/pipelines
c2d2ae5
@tom-andersen
Fix
a8361ca
@tom-andersen
Spotless
a0da150
@tom-andersen
Spotless
0ce7d4f
@tom-andersen
Rename .java to .kt
ab5f217
@tom-andersen
Work
dec61c0
@tom-andersen
Copyright
e5734cd
@tom-andersen
Merge remote-tracking branch 'origin/main' into tomandersen/pipelines
8976978
@tom-andersen
spotless
70bdf62
@tom-andersen
docStubs fix
fc8b2d1
@tom-andersen
fix
1e7e72e
@tom-andersen
fix
35bcff7
@tom-andersen
More tests
3cb1886
@tom-andersen
Merge remote-tracking branch 'origin/main' into tomandersen/pipelines
cea0c48
@tom-andersen
Refactor and more tests.
5abf13f
@tom-andersen
Add tests
ef7cbda
@tom-andersen
Cleanup
ca31612
@tom-andersen
Merge branch 'feat/pipelines' into tomandersen/pipelines
63cd54e
@tom-andersen
Generic Stage and Refactor
c7605b6
@tom-andersen
Fix docStubs task
6842a83
@tom-andersen
Spotless fix
08af748
@tom-andersen
Generate api.txt
fea5b06
@tom-andersen
Make more of the API internal
711b852
@tom-andersen
Make more of the API internal
1ccea4d
MarkDuckworth
MarkDuckworth reviewed Dec 18, 2025
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of files, up to firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/FunctionRegistry.kt.

Nothing major other than making sure realtime pipelines stay private for launch

MarkDuckworth
MarkDuckworth approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 22, 2025

The public api surface has changed for the subproject firebase-firestore:
error: Removed method com.google.firebase.firestore.Pipeline.findNearest(String,com.google.firebase.firestore.VectorValue,com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure) [RemovedMethod]
error: Removed method com.google.firebase.firestore.Pipeline.findNearest(String,com.google.firebase.firestore.pipeline.Expression,com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure) [RemovedMethod]
error: Removed method com.google.firebase.firestore.Pipeline.findNearest(com.google.firebase.firestore.pipeline.Field,com.google.firebase.firestore.VectorValue,com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@wu-hui wu-hui added cla: yes Override cla and removed cla: no labels Dec 22, 2025
@google-cla google-cla bot added cla: no and removed cla: yes Override cla labels Dec 22, 2025
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 22, 2025

The public api surface has changed for the subproject firebase-firestore:
error: Removed method com.google.firebase.firestore.Pipeline.findNearest(String,com.google.firebase.firestore.VectorValue,com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure) [RemovedMethod]
error: Removed method com.google.firebase.firestore.Pipeline.findNearest(String,com.google.firebase.firestore.pipeline.Expression,com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure) [RemovedMethod]
error: Removed method com.google.firebase.firestore.Pipeline.findNearest(com.google.firebase.firestore.pipeline.Field,com.google.firebase.firestore.VectorValue,com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@wu-hui wu-hui force-pushed the feat/pipeline/public-preview branch from 4e584f5 to c470ce5 Compare December 23, 2025 00:15
@wu-hui wu-hui requested a review from nk-1983 December 23, 2025 00:22
@wu-hui wu-hui force-pushed the feat/pipeline/public-preview branch from c470ce5 to 89670ee Compare December 23, 2025 16:32
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 23, 2025

The public api surface has changed for the subproject firebase-firestore:
error: Attempted to change parameter name from documents to results in method com.google.firebase.firestore.pipeline.SampleStage.withDocLimit [ParameterNameChange]
error: Attempted to change parameter name from documents to results in method com.google.firebase.firestore.pipeline.SampleStage.Companion.withDocLimit [ParameterNameChange]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@wu-hui wu-hui force-pushed the feat/pipeline/public-preview branch from 89670ee to 6e79f00 Compare December 23, 2025 18:28
@wu-hui wu-hui added cla: yes Override cla and removed cla: no labels Dec 23, 2025
@google-cla google-cla bot added cla: no and removed cla: yes Override cla labels Dec 23, 2025
@VinayGuthal VinayGuthal added cla: yes Override cla and removed cla: no labels Dec 23, 2025
@google-cla google-cla bot added cla: no and removed cla: yes Override cla labels Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

+1 more reviewer

@nk-1983 nk-1983 nk-1983 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarkDuckworth MarkDuckworth

@nk-1983 nk-1983

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wu-hui @google-oss-bot @MarkDuckworth @nk-1983 @VinayGuthal @davidmotson @tom-andersen