-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add a mechanism to prevent concurrent token refreshes #15493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
88fc659 to
4608cf2
Compare
When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService. This PR makes sure only one token refresh is happening at the same time
4608cf2 to
b59cc72
Compare
ncooke3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 1 | ||
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 2 | ||
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 1 | |
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 2 | |
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 3 | |
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token, ...) } // 1 | |
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token, ...) } // 2 | |
| /// Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token, ...) } // 3 |
| let currentToken = service.accessToken | ||
| return try await refreshCoalescer.coalescedRefresh( | ||
| currentToken: currentToken | ||
| ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about calls within quick succession that have a different token?
Example
Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token1, ...) } // 1
Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token1, ...) } // 2
Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token2, ...) } // 3The last call has a different token so that would cancel out the first two calls? Was this a realistic scenario within your sample app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question !
In our sample app the refresh request would be executed multiple time with the same token (the one that expired)
Yeah requesting a different token would cancel the previous requests. Do you think the scenario you're describing could happen ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, I don't think there are multiple access tokens, each with their own refresh lifecycle. I'll look within the SDK.
cc: @pashanka
When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService.
This PR makes sure only one token refresh is happening at the same time
Discussion
Testing
Testing scenario:
API Changes