Skip to content

Conversation

@lilpit
Copy link

@lilpit lilpit commented Nov 13, 2025

When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService.

This PR makes sure only one token refresh is happening at the same time

Discussion

Testing

  • Added some unit tests to test concurrent reload behaviors
  • Tested this branch in our sample project where we reproduce the issue -> the issue is gone
    Testing scenario:
  • Open the sample app
  • Wait for 1 hour for token expirtation
  • Re open the sample app -> only one token refresh is performed instead of multiple one

API Changes

  • No API changes

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@google-cla
Copy link

google-cla bot commented Nov 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

When multiple different firebase services require a token refresh at the same time, multiple token refresh can be triggered at the same time inside the SecureTokenService.

This PR makes sure only one token refresh is happening at the same time
@lilpit lilpit force-pushed the concurrentRequestsHandling branch from 4608cf2 to b59cc72 Compare November 13, 2025 15:02
@ncooke3 ncooke3 self-requested a review November 13, 2025 16:38
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment on lines +30 to +32
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 1
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 2
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 1
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 2
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(backend: backend, ...) } // 3
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token, ...) } // 1
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token, ...) } // 2
/// Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token, ...) } // 3

let currentToken = service.accessToken
return try await refreshCoalescer.coalescedRefresh(
currentToken: currentToken
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about calls within quick succession that have a different token?

Example

Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token1, ...) }  // 1
Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token1, ...) }  // 2
Task { try await tokenRefreshCoalescer.coalescedRefresh(currentToken: token2, ...) }  // 3

The last call has a different token so that would cancel out the first two calls? Was this a realistic scenario within your sample app?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question !
In our sample app the refresh request would be executed multiple time with the same token (the one that expired)

Yeah requesting a different token would cancel the previous requests. Do you think the scenario you're describing could happen ?

Copy link
Member

@ncooke3 ncooke3 Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I don't think there are multiple access tokens, each with their own refresh lifecycle. I'll look within the SDK.

cc: @pashanka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants