Skip to content

[4/4] Api fixups #8911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: wuandy/RealPpl_3
Choose a base branch
from
Open

[4/4] Api fixups #8911

wants to merge 1 commit into from

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 8, 2025

No description provided.

@wu-hui wu-hui requested review from a team as code owners April 8, 2025 22:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b12a7a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch from 33caa24 to 5065573 Compare April 14, 2025 18:34
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from 61c5400 to 75e26e7 Compare April 14, 2025 18:34
MarkDuckworth
MarkDuckworth reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wu-hui, allocation of work is what I see that needs to be done for the TODOs in this PR. For now, I will not start on these to avoid more conflicts.

packages/firestore/rollup.config.js
json({ preferConst: true }),
terser(util.manglePrivatePropertiesOptions)
json({ preferConst: true })
//terser(util.manglePrivatePropertiesOptions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be fixed before merging to allow packaging. I can do this if you want.

packages/firestore/rollup.shared.js
if (warning.code === 'CIRCULAR_DEPENDENCY') {
throw new Error(warning);
// TODO reenable. This is a temp workaround to allow build
//throw new Error(warning);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be fixed before merging to allow packaging. I can do this if you want.

@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch from 5065573 to 5cb4499 Compare April 24, 2025 13:59
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from 75e26e7 to 40d7b0d Compare April 24, 2025 14:00
@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch from 5cb4499 to 90b6e29 Compare April 29, 2025 19:45
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from 40d7b0d to ddf21ca Compare April 29, 2025 19:45
@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch from 90b6e29 to 5cbd519 Compare May 13, 2025 20:19
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from ddf21ca to c1f6f8e Compare May 13, 2025 20:19
@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch from 5cbd519 to d1b4016 Compare May 16, 2025 18:09
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from c1f6f8e to 474cbd8 Compare May 16, 2025 18:09
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from 474cbd8 to 1f92813 Compare May 29, 2025 06:05
@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch from d1b4016 to 3ef4e6f Compare May 29, 2025 06:05
@wu-hui wu-hui force-pushed the wuandy/RealPpl_4 branch from 1f92813 to 0eb1e66 Compare June 27, 2025 18:34
@wu-hui wu-hui force-pushed the wuandy/RealPpl_3 branch 2 times, most recently from 0175188 to 4fe535b Compare October 14, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wu-hui @MarkDuckworth