Skip to content

Wire up app check provider to telemetry service #9239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

Wire up app check provider to telemetry service #9239

merged 1 commit into from
Sep 5, 2025
+19 −3

Conversation

tonybaroneee
Copy link

@tonybaroneee tonybaroneee commented Sep 4, 2025 •
edited
Loading

Next PR will use the token from the app check provider to pass along as a header.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d0f5f1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tonybaroneee tonybaroneee force-pushed the telemetry-app-check branch 2 times, most recently from 6aac943 to 107b856 Compare September 4, 2025 17:52
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/telemetry

    TypeBase (50a3bf4)Merge (de1ddcd)Diff
    browser2.70 kB2.89 kB+193 B (+7.2%)
    main3.29 kB3.48 kB+193 B (+5.9%)
    module2.70 kB2.89 kB+193 B (+7.2%)

  • firebase

    TypeBase (50a3bf4)Merge (de1ddcd)Diff
    firebase-telemetry.js77.5 kB77.6 kB+103 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vcxXwHLyCH.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/telemetry

    • captureError

      Size

      TypeBase (50a3bf4)Merge (de1ddcd)Diff
      size1.70 kB1.81 kB+111 B (+6.5%)
      size-with-ext-deps58.2 kB58.3 kB+111 B (+0.2%)

    • flush

      Size

      TypeBase (50a3bf4)Merge (de1ddcd)Diff
      size1.12 kB1.23 kB+111 B (+9.9%)
      size-with-ext-deps56.9 kB57.0 kB+111 B (+0.2%)

    • getTelemetry

      Size

      TypeBase (50a3bf4)Merge (de1ddcd)Diff
      size1.08 kB1.20 kB+111 B (+10.2%)
      size-with-ext-deps64.0 kB64.1 kB+111 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PHgVmJ1m1G.html

@tonybaroneee tonybaroneee marked this pull request as ready for review September 5, 2025 17:03
@tonybaroneee tonybaroneee requested a review from a team as a code owner September 5, 2025 17:03
@tonybaroneee tonybaroneee merged commit ec64f4f into telemetry Sep 5, 2025
42 of 45 checks passed
@tonybaroneee tonybaroneee deleted the telemetry-app-check branch September 5, 2025 17:04
@LanderBeeuwsaert LanderBeeuwsaert mentioned this pull request Sep 11, 2025
Open
@firebase firebase locked and limited conversation to collaborators Oct 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbrook andrewbrook andrewbrook approved these changes

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonybaroneee @google-oss-bot @andrewbrook