Update registerStateListener internal method signature and structure #9336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement InitializeAuth changes for BYO-CIAM Firebase Auth * Removing white space * Addressing review comments * Adding Unit test for initializeAuth with TenantConfig dependency * Running yarn run demo * Update doc
* Throw not supported exception in _performApiRequest
* Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019) * Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019) * Implement exchangeToken public api * Using expiry_in returned by backend * Addressing review comments and adding some Unit test * Docgen * Addressing review comments and adding some Unit test * Typo * yarn docgen * Fixing typo * yarn run format
* Write Firebase Token to Auth instance * yarn run format * Fix unit test and run yarn docgen:all * Address comments
* Write Firebase Token to Auth instance * yarn run format * Fix unit test and run yarn docgen:all * getFirebaseToken Auth Interop method for BYO-CIAM * Add unit test * Adding Unit test * Running yarn docgen:all * Use getToken instead of getFirebaseToken * Adding Unit test * yarn run format * Remove unused method
* Maintain persistence for firebaseToken in AuthImpl object * Adding Unit Test for auth_impl firebaseToken
* Implement signout() for BYO-CIAM
Implement Token refresh mechanism for BYO-CIAM. ### Testing - Tested using unit test - BYO-CIAM methods in demo app.
* Refresh Firebase Token Demo App changes. * take IdpConfig id as input * yarn run format * Remove unwanted comments * Remove unwanted comments
* Update the token refresh time from 30 seconds to 1 minute and add unit tests * Run yarn run demo
#9298) * Remove firebaseToken from persistence if tokenRefreshHandler is not set and token is expired * Update to call signOut instead * update comment * minnor changes
* Demo app improvements. * yarn run format * review comments * add unset RegionalAuth button
* Add firebaseInterop getToken method call from BYO-CIAM demo app * running yarn run format
…or… (#9325) * Throw UnsupportedOperationException in FirebaseAuthInterop getUid for regionalAuth * yarn run format * Updating the chrome_validated_version for tests * Address comments
mansisampat
requested review from
a team,
NhienLam,
Xiaoshouzi-gh,
lisajian,
pashanka and
sam-gc
as code owners
|
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (392,654 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Testing