-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add MCP tool to list functions #9369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @brittanycho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new Multi-Cloud Platform (MCP) tool designed to list all deployed Firebase functions within a project. It fulfills a feature request by providing a programmatic equivalent to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new MCP tool, list_functions, to list all deployed functions in a Firebase project. The implementation is straightforward and follows existing patterns. I've identified a couple of minor issues: the readOnlyHint annotation is set incorrectly, and the fallback value for missing memory information is inconsistent with other tools. My suggestions aim to correct these for better accuracy and consistency.
^iiuc the context for this tool, I disagree with these gemini suggestions - clarified further in follow-up comments to the suggestions |
taeold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry in CHANGELOG.md
Co-authored-by: Daniel Lee <[email protected]>
Co-authored-by: Daniel Lee <[email protected]>
Fulfills a FR to add
firebase functions:listtool equivalent as an MCP tool