-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add export/import of app distribution test cases as YAML. #9397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kaibolay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firebase App Distribution CLI by enabling the export and import of test cases using YAML files. This new capability allows developers to version control, share, and programmatically manage their app testing workflows, providing greater flexibility and integration with existing development practices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds functionality to import and export App Distribution test cases as YAML files. The changes include new client methods for interacting with the test case API, a YAML helper for data conversion, and new CLI commands for import/export. The implementation is solid, with good test coverage for the new logic. I have a couple of suggestions to improve error handling consistency and robustness in the YAML parsing logic.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces functionality to import and export App Distribution test cases as YAML files. The changes include new commands, updates to the App Distribution client for test case APIs, new types, and a YAML helper for serialization/deserialization. The implementation is well-structured and includes corresponding tests.
My review focuses on improving robustness, ensuring test correctness, and promoting consistent error handling. I've identified a bug in a test case related to string interpolation, suggested using Promise.allSettled for more resilient batch processing in the import command, and pointed out areas for improved error logging and minor code simplification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some small nits
Description
Add functionality to import and export test cases as YAML files.
Scenarios Tested
Example:
Sample Commands