Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
12b9257
adds listServices fn and adds trigger to endpointFromService fn
brittanycho Oct 31, 2025
0a30722
updates functions-list to use listServices to use cloud run api instead
brittanycho Oct 31, 2025
df189ee
adds listServices tests
brittanycho Oct 31, 2025
66cf473
fix linting errors
brittanycho Oct 31, 2025
3af536c
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Oct 31, 2025
f6ef8c0
Update src/commands/functions-list.ts
brittanycho Nov 3, 2025
d9fd843
Update src/gcp/runv2.ts
brittanycho Nov 3, 2025
84725cf
corrects import error
brittanycho Nov 3, 2025
6a45457
add relevant labelSelectors
brittanycho Nov 4, 2025
9cedf12
adding v1 fns in
brittanycho Nov 5, 2025
481d02f
adding in deduplication
brittanycho Nov 5, 2025
0362303
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 5, 2025
d4ed0f9
Update src/gcp/runv2.ts
brittanycho Nov 5, 2025
2de426f
linting
brittanycho Nov 5, 2025
7cb75d8
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 6, 2025
4d06024
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 8, 2025
3712d0c
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 10, 2025
d1986ac
follow-up on feedback: move parts of implementation to backend.ts, ad…
brittanycho Nov 11, 2025
8f1c06d
correct lint error
brittanycho Nov 11, 2025
1cef2a6
Update src/commands/functions-list.ts
brittanycho Nov 11, 2025
0de7514
addressing feedback on parsing
brittanycho Nov 11, 2025
66e5d6f
feat: upgrade functions::list to use Cloud Run API and bump version t…
brittanycho Nov 11, 2025
c1f2e7b
adjust how v2 functions are being called from listServices
brittanycho Nov 11, 2025
bd8ea09
add updated tests to backend.spec.ts
brittanycho Nov 11, 2025
86ef3f6
addresses feedback from code review
brittanycho Nov 12, 2025
9287590
updates changelog
brittanycho Nov 12, 2025
896d3a1
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 12, 2025
a38b669
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 12, 2025
c253ae9
addresses feedback
brittanycho Nov 13, 2025
0779bff
Merge branch 'master' into fr/cloud-run-fns-list
brittanycho Nov 13, 2025
a36e9d9
Merge remote-tracking branch 'origin/fr/cloud-run-fns-list' into fr/c…
brittanycho Nov 13, 2025
5acc3cf
Update src/gcp/runv2.ts
brittanycho Nov 13, 2025
812fda9
correct linting errors
brittanycho Nov 13, 2025
4ebc27b
Update src/deploy/functions/backend.spec.ts
brittanycho Nov 14, 2025
369c402
updates error handling and tests
brittanycho Nov 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- [Added] support for new google-genai plugin during `init genkit` (#8957)
- Updated to v2.17.1 of the Data Connect emulator, which fixes an admin SDK bug for operation without argument #9449 (#9454).
- Upgraded functions::list command to use cloud run api for v2 functions (#9425)
Comment on lines +1 to +3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove and add our own changelist bullet?

35 changes: 27 additions & 8 deletions src/commands/functions-list.ts
Original file line number Diff line number Diff line change
@@ -1,38 +1,57 @@
import { Command } from "../command";
import * as args from "../deploy/functions/args";
import { needProjectId } from "../projectUtils";
import { Options } from "../options";
import { requirePermissions } from "../requirePermissions";
import * as backend from "../deploy/functions/backend";
import { logger } from "../logger";
import * as Table from "cli-table3";
import { Options } from "../options";
import { FunctionsPlatform } from "../deploy/functions/backend";

type PLATFORM_DISPLAY_NAME = "v1" | "v2" | "run";
const PLATFORM_TO_DISPLAY_NAME: Record<FunctionsPlatform, PLATFORM_DISPLAY_NAME> = {
gcfv1: "v1",
gcfv2: "v2",
run: "run",
};

export const command = new Command("functions:list")
.description("list all deployed functions in your Firebase project")
.before(requirePermissions, ["cloudfunctions.functions.list"])
.before(requirePermissions, ["cloudfunctions.functions.list", "run.services.list"])
.action(async (options: Options) => {
const projectId = needProjectId(options);
const context = {
projectId: needProjectId(options),
projectId,
} as args.Context;

const existing = await backend.existingBackend(context);
const endpointsList = backend.allEndpoints(existing).sort(backend.compareFunctions);
const endpoints = backend.allEndpoints(existing);

endpoints.sort(backend.compareFunctions);

if (endpoints.length === 0) {
logger.info(`No functions found in project ${projectId}.`);
return [];
}

const table = new Table({

Check warning on line 37 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value
head: ["Function", "Version", "Trigger", "Location", "Memory", "Runtime"],
style: { head: ["yellow"] },
});
for (const endpoint of endpointsList) {
}) as any;

Check warning on line 40 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type

for (const endpoint of endpoints) {
const trigger = backend.endpointTriggerType(endpoint);
const availableMemoryMb = endpoint.availableMemoryMb || "---";
const entry = [
endpoint.id,
endpoint.platform === "gcfv2" ? "v2" : "v1",
PLATFORM_TO_DISPLAY_NAME[endpoint.platform] || "v1",
trigger,
endpoint.region,
availableMemoryMb,
endpoint.runtime,
];
table.push(entry);

Check warning on line 53 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe call of an `any` typed value

Check warning on line 53 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe member access .push on an `any` value
}
logger.info(table.toString());

Check warning on line 55 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe call of an `any` typed value

Check warning on line 55 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe member access .toString on an `any` value

Check warning on line 55 in src/commands/functions-list.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `Error`
return endpointsList;
return endpoints;
});
1 change: 0 additions & 1 deletion src/deploy/functions/args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export interface Context {
existingBackendPromise?: Promise<backend.Backend>;
unreachableRegions?: {
gcfV1: string[];
gcfV2: string[];
run: string[];
};

Expand Down
Loading
Loading