Skip to content

Conversation

@MengqinShen
Copy link
Contributor

@MengqinShen MengqinShen commented Dec 23, 2025

In this test flow, The response was []. After the fix, it responds with a story as defined in the flow.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug within the Anthropic plugin where streaming responses could lead to an empty content field, effectively causing a lack of response. The changes ensure that the content is always properly extracted and formatted from the API's response. Additionally, it standardizes the internal representation of various content types by wrapping them within a unified Part object, promoting consistency in how content is handled throughout the system, especially in streaming contexts.

Highlights

  • Fix for No Response in Streaming Flows: The primary issue of receiving no response in streaming say_hi_stream flows has been resolved by ensuring that the content field is always correctly populated from the API response, regardless of whether the operation is streaming or not.
  • Standardized Content Part Representation: Content parts, such as TextPart and ToolRequestPart, are now consistently wrapped within a Part object. This change standardizes the internal data structure for content representation across both streaming chunks and general content conversion, improving consistency and handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves a bug causing empty responses in streaming mode with the Anthropic model. The core change correctly processes content from the final streaming message. The PR also includes necessary type corrections, ensuring that TextPart and ToolRequestPart are properly wrapped within Part objects as required by the genkit data model. The changes are well-implemented. I've added one suggestion to improve test coverage for this fix to prevent future regressions.

@MengqinShen MengqinShen requested a review from yesudeep December 23, 2025 19:43
@MengqinShen MengqinShen marked this pull request as ready for review December 23, 2025 20:37
@MengqinShen MengqinShen merged commit e42265e into main Dec 23, 2025
10 checks passed
@MengqinShen MengqinShen deleted the elisa/fix(py)/anthropic-hello branch December 23, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants