Skip to content

Conversation

@hugoaguirre
Copy link
Contributor

Checklist (if applicable):

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hugoaguirre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of thoughtSignature metadata within the Google GenAI plugin. It ensures that thoughtSignature values are correctly captured and propagated during conversions between the Google GenAI API's genai.Part and the internal ai.Part structures, improving data fidelity and consistency. Additionally, it enhances error handling for unrecognized part types.

Highlights

  • ThoughtSignature Preservation (Ingress): The translateCandidate function now extracts ThoughtSignature from genai.Part objects and stores it in the ai.Part's metadata when converting from the Google GenAI format to the internal ai format.
  • ThoughtSignature Propagation (Egress): The toGeminiPart function has been updated to consistently retrieve ThoughtSignature from the ai.Part's metadata and assign it to the genai.Part.ThoughtSignature field, ensuring this metadata is correctly propagated when converting to the Google GenAI format.
  • Error Handling Improvement: The toGeminiPart function now returns a structured error for unknown part types instead of causing a panic, improving robustness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hugoaguirre hugoaguirre linked an issue Dec 24, 2025 that may be closed by this pull request
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the toGeminiPart function to better handle thoughtSignature and improves robustness by replacing a panic with a returned error. It also updates translateCandidate to include the thoughtSignature in the metadata of response parts. The refactoring is a positive change, enhancing code clarity and maintainability. However, I've identified a critical issue in translateCandidate where the thoughtSignature is unintentionally dropped for thought parts, which I've detailed in a specific comment.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hugoaguirre
Copy link
Contributor Author

Added signature to the Thought parts. Gemini documentation does not state otherwise.
Since we are manipulating Gemini parts internally, we should preserve Thought parts as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Go] thoughtSignature in tool calling using gemini 3 family

1 participant