FIR-28289 Change SUBSTRING's <start> and <count> parameters to BIGINT#196
Open
zlifb wants to merge 1 commit intofirebolt-db:gh-pagesfrom
Open
FIR-28289 Change SUBSTRING's <start> and <count> parameters to BIGINT#196zlifb wants to merge 1 commit intofirebolt-db:gh-pagesfrom
zlifb wants to merge 1 commit intofirebolt-db:gh-pagesfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Thank you for the PR @zlifb - is this behavior already live, or do we need to wait for a release version to be tagged on the ticket? |
Author
|
@molly-firebolt The change is merged in master, but not included in the 3.30 release. So it will be in for 3.31 I assume. I tried to tag the Jira ticket but there seems to be no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackDB PR: https://github.com/firebolt-analytics/packdb/pull/8531 .
We used to define the signature of
substringfunction following PostgreSQL, which has<start>and<count>parameters defined asINTEGER. CallingsubstringwithBIGINTvalues for these parameters fail in PostgreSQL, and we kept the same behavior.However, we agreed that this is not very convenient. Supporting
BIGINTtypes for these parameters should be a natural extension. It does not hurt our "PostgreSQL compliant" claim. In addition, given that we still produceBIGINTfor arithmetic addition of integers, this is just convenient for our user to make in-position call to other functions.