feat: add article, collection, and help_center models #73
Conversation
dbt_project.yml
Outdated
| version: '1.3.0' | ||
| require-dbt-version: [">=1.3.0", "<3.0.0"] | ||
| version: '1.4.0' | ||
| require-dbt-version: [">=1.4.0", "<3.0.0"] |
There was a problem hiding this comment.
| require-dbt-version: [">=1.4.0", "<3.0.0"] | |
| require-dbt-version: [">=1.3.0", "<3.0.0"] |
fivetran-catfritz
left a comment
fivetran-catfritz
left a comment
There was a problem hiding this comment.
Looking great. A few more adjustments, and then we can mark this as accepted!
There was a problem hiding this comment.
This model should be removed in favor of the final model.
There was a problem hiding this comment.
In general final models shouldn't have as complex of logic necessarily built in, which is why I left the intermediate as the layer between staging and final. Even though it's somewhat a "no-op" at the moment, it's possible that other finals might be buit leveraging pieces of the intermediate. I'm happy to remove, but in general I didn't believe it to be best practice to have final reading from stg_ layers.
There was a problem hiding this comment.
Thanks for raising this. In our package design, we only introduce an intermediate layer when it provides meaningful transformation or reuse. Since this intermediate is currently a passthrough, keeping it would add complexity without much benefit. If future logic requires an intermediate, we can introduce it then, but for now keeping the final model directly on top of staging is consistent with the rest the other end models in this package.
That said, if you’d like to keep this structure in your fork for your process, that’s more than completely fine! We can update the format on our branch before release.
There was a problem hiding this comment.
Add the contents from int_intercom__article_enhanced here, so it's easy to find.
models/intercom.yml
Outdated
| - name: _fivetran_end | ||
| description: Timestamp to record the time when a record became inactive in the source system. | ||
|
|
||
| - name: int_intercom__article_enhanced |
There was a problem hiding this comment.
Can remove thanks!
fivetran-catfritz
changed the base branch from
main
to
feature/article-models
|
Merged and continued in #74. |
* feat: add article, collection, and help_center models (#73) * feat: add article, collection, and help_center models * add changelog and verions updates * Update CHANGELOG.md * updating final model * updating final model * updating version feedback * updating per PR feedback to move intermediate model to final * fix quoting issues * add consistency test * add consistency test * update format * changelog * changelog * Generate dbt docs via GitHub Actions * updates * Generate dbt docs via GitHub Actions * remove extra whitespace * formatting * Generate dbt docs via GitHub Actions * formatting again * Generate dbt docs via GitHub Actions * Update README.md * Update models/intercom__article_enhanced.sql Co-authored-by: Jamie Rodriguez <[email protected]> * review updates * run_models * Generate dbt docs via GitHub Actions * run_models * changelog * Update README.md Co-authored-by: Jamie Rodriguez <[email protected]> --------- Co-authored-by: Justin Hiza <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jamie Rodriguez <[email protected]>
2 participants
Please provide your name and company
Justin Hiza - isolved
Link the issue/feature request which this PR is meant to address
#72
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
staging models necessary to materialize an articles int model
How did you validate the changes introduced within this PR?
developed, ran and tested locally
Which warehouse did you use to develop these changes?
databricks
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?
If you had to summarize this PR in an emoji, which would it be?
💃
Feedback
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)