Support environments in Worker configs

[jamesopstad]

resolves #29

This adds support for the CLOUDFLARE_ENV environment variable to determine the environment that is used in the Worker config.

When updating the versions of Wrangler and Miniflare, I had to make changes to the Workflow tests to reflect changes in the implementation. I have also updated all the compatibility dates to the most recent.

Note that the environment variable will not work if provided in a .env file. Vite only automatically provides values from .env (prefixed with VITE_) to code rather than config. The loadEnv function (https://vite.dev/guide/api-javascript.html#loadenv) needs to be used to access variables from .env elsewhere (by default this only loads env variables prefixed with VITE_).

Do you think we should call loadEnv in the plugin in so that the value can be read from .env files?

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/flarelabs-net/vite-plugin-cloudflare/@flarelabs-net/vite-plugin-cloudflare@127

commit: fbe0fb3

[jamesopstad]

I tried to use vi.stubEnv (https://vitest.dev/api/vi.html#vi-stubenv) here instead of changing process.env in the Vite config. It didn't work though (I think because the Vite config has already run by the time we run the test).

[dario-piotrowicz]

Looks good to me, I just left some minor comments 🙂

[dario-piotrowicz]

Do you think we should call loadEnv in the plugin in so that the value can be read from .env files?

That sounds like a good idea, wrangler does read .env files for config purposes so this would be consistent with that

But I don't know if loadEnv picks up more files than wrangler (I don't think it loads .env.local files for example: wrangler code) ideally if this were implemented I think it should work as closely as possible to the way wrangler does? 🤔

[jamesopstad]

That sounds like a good idea, wrangler does read .env files for config purposes so this would be consistent with that

But I don't know if loadEnv picks up more files than wrangler (I don't think it loads .env.local files for example: wrangler code) ideally if this were implemented I think it should work as closely as possible to the way wrangler does? 🤔

This is only for use within the plugin itself though so we would only use it to get the CLOUDFLARE_ENV value. Vite already provides .env variables to user code (if they're prefixed with VITE_).

[dario-piotrowicz]

This is only for use within the plugin itself though so we would only use it to get the CLOUDFLARE_ENV value. Vite already provides .env variables to user code (if they're prefixed with VITE_).

yeah that's a good point, yes I would be in favour of calling loadEnv then 👍

[petebacondarwin]

Approved with some nits.