This repository was archived by the owner on Mar 11, 2025. It is now read-only.
pre-bundling follow ups #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
force-pushed
the
pbd/prebundle-follow-ups
branch
2 times, most recently
from
407efbe to
d3a5b82
Compare
dario-piotrowicz
approved these changes
Oct 24, 2024
Contributor
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me 😄
Thanks for addressing the spots I missed with my prebundling PR 🙏
Now that we are prebundling, and can turn on npdejs_compat, some of the hacks from before are no longer needed. - remove the fake process global - remove the workerd custom import module - remove the unsafeUseModuleFallbackService property - consolidate environment options creation - move vite override to the workspace catalog
dario-piotrowicz
force-pushed
the
pbd/prebundle-follow-ups
branch
from
9b12b1c to
d933787
Compare
Contributor
|
There was a regression in this PR that means you now can't override the output directory for a Worker in the Vite config (this was why I used |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are prebundling, and can turn on npdejs_compat, some of the hacks from before are no longer needed.