feat: Add dockerhub image for orderflow proxy sender #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
Mar 26, 2025
.github/workflows/release.yaml
Outdated
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-receiver | ||
| images: | | ||
| ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-receiver | ||
| flashbots/tdx-orderflow-proxy-receiver |
There was a problem hiding this comment.
I think we want to remove the tdx prefix, as this will/can be used for other tees too.
maybe buildernet-orderflow-proxy, or just orderflow-proxy 🤔
There was a problem hiding this comment.
I removed the prefix. But I left the suffix because there are two images one for receiver and one for sender.
metachris
reviewed
Mar 26, 2025
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-receiver | ||
| images: | | ||
| ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}-receiver |
There was a problem hiding this comment.
I think GHCR only allows images for the specific repo name, but not if they have such a suffix (which is also why the release CI step failed last time). Maybe we only push to Docker Hub?
Or a single image that can be used for both sender and receiver?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
As part of the buildernet-playground. Orderflow proxy sender is run outside alongside builder-hub. So to facilitate running all orchestrated in the playground, we need an image of orderflow proxy sender binary to be built and pushed as well
📚 References
✅ I have run these commands
make lintmake testgo mod tidy