Skip to content

restore_landed_orders: fix restore for bundle with refund #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+7 −7
Open

restore_landed_orders: fix restore for bundle with refund #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e1d1c3
restore_landed_orders: fix restore for bundle with refund
dvush Oct 24, 2025
86afa8d
redistribution: downgrade legacy warnings
dvush Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/rbuilder/src/backtest/redistribute/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ where
warn!("Block has no bundles");
}
if share_bundles == 0 {
warn!("Block has no share bundles");
debug!("Block has no share bundles");
}

let block_profit = if built_block_data.profit.is_positive() {
Expand Down Expand Up @@ -591,7 +591,7 @@ fn split_orders_by_identities(
}

if !protect_signer_seen {
warn!("No orders from protect signer");
debug!("No orders from protect signer");
}

let mut included_orders_by_address: Vec<(Address, Vec<OrderId>)> =
Expand Down
10 changes: 5 additions & 5 deletions crates/rbuilder/src/backtest/restore_landed_orders/find_landed_orders.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl SimplifiedOrder {
)],
),
Order::Bundle(bundle) => {
let (refund_percent, receiver_hash) = if let Some(refund) = &bundle.refund {
let (refund_percent, refund_payer_hash) = if let Some(refund) = &bundle.refund {
(refund.percent as usize, Some(refund.tx_hash))
} else {
(0, None)
Expand All @@ -55,10 +55,10 @@ impl SimplifiedOrder {
.list_txs_revert()
.into_iter()
.map(|(tx, revert)| {
let tx_refund_percent = if Some(tx.hash()) == receiver_hash {
0
} else {
let tx_refund_percent = if Some(tx.hash()) == refund_payer_hash {
refund_percent
} else {
0
};
OrderTxData::new(tx.hash(), revert, tx_refund_percent)
})
Expand Down Expand Up @@ -1000,7 +1000,7 @@ mod tests {
refund: Some(BundleRefund {
percent: 10,
recipient: Default::default(),
tx_hash: hash(0x01),
tx_hash: hash(0x02),
delayed: false,
}),
refund_identity: None,
Expand Down
Loading