JSON serialization for graph types and PCG#1633
Closed
elliottslaughter wants to merge 2 commits intoflexflow:masterfrom
Closed
JSON serialization for graph types and PCG#1633elliottslaughter wants to merge 2 commits intoflexflow:masterfrom
elliottslaughter wants to merge 2 commits intoflexflow:masterfrom
Conversation
elliottslaughter
changed the title
Contributor
Author
|
Duplicates logic in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1633 +/- ##
==============================
==============================
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds JSON serialization support for the various graph types under
utils/graph. This is necessary to add the JSON serialization for (mapped) PCG, which we need to pass data around between various stages of the compiler/runtime execution pipeline.The first commit was generated by Claude but I'll do a pass to review and clean up its output, as well as generate tests. Still currently in progress.
This change is