Conversation
pklaschka
left a comment
pklaschka
left a comment
There was a problem hiding this comment.
Overall, great work. There are a few concerns here and there (as aggressive caching can be -- shall we say -- annoying), other than that, I think it looks good 🙂
| <filesmatch "\.(ico|flv|jpg|jpeg|png|gif|css|swf)$"> | ||
| Header set Cache-Control "max-age=2678400, public" | ||
| </filesmatch> |
There was a problem hiding this comment.
See the above comment regarding image caching
There was a problem hiding this comment.
Hmm, please correct if I am wrong, but for files with endings *.ico/*.jpg/... we set a header control instruction with max-age of 1 month (60s * 60m * 24h * 31d = 2678400s). Is that not the same caching time span as in mod_expires above?
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
Co-authored-by: Pablo Klaschka <pklaschka@users.noreply.github.com>
| ExpiresByType text/x-javascript "access 1 month" | ||
| ExpiresByType application/x-shockwave-flash "access 1 month" | ||
| ExpiresByType image/x-icon "access 1 year" | ||
| ExpiresDefault "access 1 month" |
There was a problem hiding this comment.
I don't know if this will, by default, affect HTML caching. I'll have to check that later...
There was a problem hiding this comment.
It affects the expiration time for all documents if not specified by ExpiresByType (see Apache Module mod_expires#ExpiresDefault)
There was a problem hiding this comment.
In this case, we have to check how this affects the dynanic content in different browsers. If a browser caches the movie index page for a month without revalidatung it, that wouldn't be good.
pklaschka
left a comment
pklaschka
left a comment
There was a problem hiding this comment.
See the previous comments 😜
2 participants
No description provided.