Skip to content

Remove commands/ indirection layer, route directly through SKILL.md#13

Open
adalton wants to merge 1 commit intomainfrom
andalton/remove-commands
Open

Remove commands/ indirection layer, route directly through SKILL.md#13
adalton wants to merge 1 commit intomainfrom
andalton/remove-commands

Conversation

@adalton
Copy link
Copy Markdown
Contributor

@adalton adalton commented Mar 27, 2026

Summary

  • Remove all 24 commands/ wrapper files across 4 workflows (bugfix, docs-writer, skill-reviewer, triage) — they added a needless indirection hop that duplicated routing logic already in SKILL.md and the controller
  • Update SKILL.md to be the single entry point for all platforms (Cursor, Claude Code, Gemini CLI), routing directly to the controller or skill files
  • Fix /unattended routing to bypass the controller (it's a separate orchestrator), fold skill-reviewer guidelines loading into numbered steps, and standardize frontmatter to "Activated by phases"
  • Update all READMEs, CONTRIBUTING.md, and INSTALL.md to reflect the direct routing model

Test plan

  • Verify bugfix workflow: reference @bugfix in Cursor, invoke /assess, /diagnose, /unattended — confirm SKILL.md routes correctly
  • Verify docs-writer workflow: reference @docs-writer in Cursor, invoke /gather — confirm controller dispatches
  • Verify triage workflow: reference @triage, invoke /scan — confirm direct skill routing works
  • Verify skill-reviewer: invoke /review bugfix — confirm guidelines load before review skill
  • Verify Claude Code: ask to "run the assess phase" — confirm CLAUDE.md → SKILL.md → controller routing
  • Verify no stale commands/ references remain (only intentional one in skill-reviewer/skills/review.md for reviewing arbitrary skill dirs)

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Documentation
    • Simplified Cursor workflow interaction by consolidating routing through main entry points instead of intermediate command wrappers
    • Updated documentation to reflect streamlined directory structure and phase-based activation model
    • Replaced command-path invocation with direct phase specification in message context for all workflows

The commands/ directories contained thin wrapper files that added a
needless indirection hop — each one just said "read the controller and
dispatch phase X," which SKILL.md and the controller already handle.

This removes all 24 command files across 4 workflows and updates
SKILL.md to be the single entry point for all platforms (Cursor, Claude
Code, Gemini CLI). Routing now goes SKILL.md → controller → skill,
or SKILL.md → skill for workflows without a controller.

Key changes:
- Delete bugfix/commands/ (11), docs-writer/commands/ (6),
  skill-reviewer/commands/ (1), triage/commands/ (6)
- Update SKILL.md routing: bugfix special-cases /unattended before
  loading controller; skill-reviewer folds guidelines loading into
  numbered steps; docs-writer adds "Activated by phases" to frontmatter
- Update all READMEs, CONTRIBUTING.md, and INSTALL.md to remove
  commands/ references and document the direct routing model
- Standardize frontmatter to "Activated by phases" across all workflows
- Update Cursor usage examples to the AI-agnostic @workflow pattern

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84a82174-aeca-496f-8528-0ae51da2a9c4

📥 Commits

Reviewing files that changed from the base of the PR and between 14b586c and 47625fc.

📒 Files selected for processing (36)
  • .cursor-plugin/INSTALL.md
  • CONTRIBUTING.md
  • README.md
  • bugfix/README.md
  • bugfix/SKILL.md
  • bugfix/commands/assess.md
  • bugfix/commands/diagnose.md
  • bugfix/commands/document.md
  • bugfix/commands/feedback.md
  • bugfix/commands/fix.md
  • bugfix/commands/pr.md
  • bugfix/commands/reproduce.md
  • bugfix/commands/review.md
  • bugfix/commands/start.md
  • bugfix/commands/test.md
  • bugfix/commands/unattended.md
  • docs-writer/README.md
  • docs-writer/SKILL.md
  • docs-writer/commands/apply.md
  • docs-writer/commands/draft.md
  • docs-writer/commands/gather.md
  • docs-writer/commands/mr.md
  • docs-writer/commands/plan.md
  • docs-writer/commands/validate.md
  • skill-reviewer/README.md
  • skill-reviewer/SKILL.md
  • skill-reviewer/commands/review.md
  • skill-reviewer/skills/review.md
  • triage/README.md
  • triage/SKILL.md
  • triage/commands/analyze.md
  • triage/commands/assess.md
  • triage/commands/report.md
  • triage/commands/run.md
  • triage/commands/scan.md
  • triage/commands/start.md
💤 Files with no reviewable changes (24)
  • bugfix/commands/pr.md
  • docs-writer/commands/mr.md
  • bugfix/commands/test.md
  • skill-reviewer/commands/review.md
  • triage/commands/scan.md
  • bugfix/commands/reproduce.md
  • docs-writer/commands/validate.md
  • bugfix/commands/feedback.md
  • triage/commands/assess.md
  • triage/commands/analyze.md
  • triage/commands/report.md
  • bugfix/commands/fix.md
  • docs-writer/commands/draft.md
  • bugfix/commands/diagnose.md
  • docs-writer/commands/apply.md
  • triage/commands/start.md
  • docs-writer/commands/gather.md
  • triage/commands/run.md
  • bugfix/commands/assess.md
  • bugfix/commands/document.md
  • docs-writer/commands/plan.md
  • bugfix/commands/start.md
  • bugfix/commands/unattended.md
  • bugfix/commands/review.md

Walkthrough

This pull request removes the thin-wrapper commands/ directory structure from multiple workflow definitions (bugfix, docs-writer, skill-reviewer, triage) and refactors activation models to use direct phase-based routing through SKILL.md as the entry point, simplifying documentation and reducing indirection layers.

Changes

Cohort / File(s) Summary
Root Installation & Contribution Docs
.cursor-plugin/INSTALL.md, CONTRIBUTING.md, README.md
Updated references to workflow activation: removed examples using @workflow/commands/<phase> syntax and replaced with direct @workflow invocation followed by phase names or intent phrases. Simplified path convention documentation to reflect entry through SKILL.md → phases model.
Bugfix Workflow
bugfix/README.md, bugfix/SKILL.md, bugfix/commands/*
Removed all command wrapper files (assess.md through unattended.md). Updated README and SKILL.md to document SKILL.md as the entry point that loads the controller and dispatches phases, with /unattended routing directly to its skill file. Changed activation terminology from "commands" to "phases".
Docs-writer Workflow
docs-writer/README.md, docs-writer/SKILL.md, docs-writer/commands/*
Deleted six command wrapper files (apply.md through validate.md). Updated README to consolidate directory structure under single skills/ tree. Updated SKILL.md frontmatter to describe phase-based activation sequence (/gather/plan/draft/validate/apply/mr).
Skill-reviewer Workflow
skill-reviewer/README.md, skill-reviewer/SKILL.md, skill-reviewer/commands/review.md, skill-reviewer/skills/review.md
Removed /review command wrapper file. Updated README and SKILL.md to establish SKILL.md as entry point that loads guidelines.md before routing to skills/review.md. Adjusted Quick Start step ordering and removed command-file checks from Orchestration & Routing validation dimensions.
Triage Workflow
triage/README.md, triage/SKILL.md, triage/commands/*
Deleted five command wrapper files (analyze.md through start.md). Updated README with new messaging pattern using direct @triage references with phase/action as quoted strings. Changed SKILL.md terminology from command-based to phase-based activation for single-bug triage trigger.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main architectural change: removing the commands/ directory layer and establishing SKILL.md as the direct entry point for routing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch andalton/remove-commands

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adalton adalton self-assigned this Mar 27, 2026
@adalton adalton requested a review from amir-yogev-gh March 27, 2026 18:22
Copy link
Copy Markdown
Collaborator

@amir-yogev-gh amir-yogev-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs further discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants