-
Notifications
You must be signed in to change notification settings - Fork 22
[Perf] Implement copy() and use while loop in serializers #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
novakov-alexey
merged 7 commits into
flink-extended:master
from
arnaud-daroussin:perf-copy-and-while
Aug 27, 2025
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
28e2484
[perf] implement specific direct-memory copy when more optimized than…
arnaud-daroussin 4908580
[perf] Replace for comprehension with while loop
arnaud-daroussin bf0d998
Improve checks on serializer: instance and binary copy
arnaud-daroussin 9d1e5ee
review: replace custom Scalatest matchers with simple test functions
arnaud-daroussin fdaaef7
review: Fix checks on arity and totalFields
arnaud-daroussin c8ad026
Rename checkBinaryCopy to checkDataViewCopy
arnaud-daroussin 945c57e
Extract type information constants
arnaud-daroussin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 3 additions & 11 deletions
14
modules/flink-common-api/src/test/scala/org/apache/flinkx/api/CatsTest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,18 @@ | ||
| package org.apache.flinkx.api | ||
|
|
||
| import cats.data.NonEmptyList | ||
| import org.apache.flink.api.common.serialization.SerializerConfigImpl | ||
| import org.apache.flink.api.common.typeinfo.TypeInformation | ||
| import org.apache.flinkx.api.serializers._ | ||
| import org.scalatest.flatspec.AnyFlatSpec | ||
| import org.scalatest.matchers.should.Matchers | ||
|
|
||
| class CatsTest extends AnyFlatSpec with Matchers with TestUtils { | ||
| implicit val stringListTi: TypeInformation[NonEmptyList[String]] = deriveTypeInformation | ||
| implicit val intListTi: TypeInformation[NonEmptyList[Int]] = deriveTypeInformation | ||
|
|
||
| def createSerializer[T: TypeInformation] = | ||
| implicitly[TypeInformation[T]].createSerializer(new SerializerConfigImpl()) | ||
|
|
||
| it should "derive for NEL[String]" in { | ||
| val ser = createSerializer[NonEmptyList[String]] | ||
| roundtrip(ser, NonEmptyList.one("doo")) | ||
| testSerializer(NonEmptyList.one("doo")) | ||
| } | ||
|
|
||
| it should "derive for NEL[Int]" in { | ||
| val ser = createSerializer[NonEmptyList[Int]] | ||
| roundtrip(ser, NonEmptyList.one(1)) | ||
| testSerializer(NonEmptyList.one(1)) | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.