Skip to content

cleanup API of AffineTransform #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup API of AffineTransform #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/AffineTransform.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ extension AffineTransform {
/// [ -sin α cos α 0 ]
/// [ 0 0 1 ]
/// ```
public init(rotationByRadians angle: CGFloat) {
public init(rotationAngle angle: CGFloat) {
let sinα = sin(angle)
let cosα = cos(angle)

Expand All @@ -131,7 +131,7 @@ extension AffineTransform {
/// ```
public init(rotationByDegrees angle: CGFloat) {
let α = angle * .pi / 180
self.init(rotationByRadians: α)
self.init(rotationAngle: α)
}
}

Expand Down Expand Up @@ -207,7 +207,7 @@ extension AffineTransform {
/// ```
public mutating func rotate(byRadians angle: CGFloat) {
self = concatenated(
AffineTransform(rotationByRadians: angle)
AffineTransform(rotationAngle: angle)
)
}

Expand Down
4 changes: 0 additions & 4 deletions Sources/CGAffineTransform.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ public extension CGAffineTransform {
self.init(scaleByX: scaleX, byY: y)
}

init(rotationAngle: CGFloat) {
self.init(rotationByRadians: rotationAngle)
}

var isIdentity: Bool {
return self == .identity
}
Expand Down