Namespace imports for better tree shaking#201
Open
devmatteini wants to merge 4 commits intofloydspace:mainfrom
Open
Namespace imports for better tree shaking#201devmatteini wants to merge 4 commits intofloydspace:mainfrom
devmatteini wants to merge 4 commits intofloydspace:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196
Hi! As you said, you already fixed it for beta release with Effect 4, but if you are still interested in the fixes for current major v1, here's the PR.
I updated every import from:
effect@effect/*packages@effect-aws/*packagesI verified the changes with
pnpm buildwhich typecheck, test and build each package.Notes
When I was testing the codegen script, I reverted the changes made from the latest AWS SDK manifests. I only kept the imports changes.