feat: exclude third level dependencies#481
Open
deathemperor wants to merge 1 commit intofloydspace:masterfrom
Open
feat: exclude third level dependencies#481deathemperor wants to merge 1 commit intofloydspace:masterfrom
deathemperor wants to merge 1 commit intofloydspace:masterfrom
Conversation
deathemperor
force-pushed
the
master
branch
from
f61f968 to
2332702
Compare
Author
|
@floydspace can you have a look at this please? I still have to use patching for this with my deployment |
Owner
|
Hey @deathemperor |
Author
|
@floydspace I've updated the code, can you run the tests again please? thanks. |
Author
|
still wish to have this done, any idea what preventing it from getting merged @floydspace ? |
|
Curious about this PR and whether it would help us reduce the zip size when comparing the zip generated by I can't see which tests are failing, but I assume that is the main thing preventing this PR from moving forward to code review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #312