feat: #1311 add allowClear and clearIcon to FormBuilderDateTimePicker#1505
Closed
majumdersubhanu wants to merge 1 commit intoflutter-form-builder-ecosystem:mainfrom
Closed
feat: #1311 add allowClear and clearIcon to FormBuilderDateTimePicker#1505majumdersubhanu wants to merge 1 commit intoflutter-form-builder-ecosystem:mainfrom
majumdersubhanu wants to merge 1 commit intoflutter-form-builder-ecosystem:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
==========================================
+ Coverage 91.06% 91.40% +0.33%
==========================================
Files 21 21
Lines 851 861 +10
==========================================
+ Hits 775 787 +12
+ Misses 76 74 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
da1e1db to
755608f
Compare
chore: add tests for FormBuilderDateTimePicker chore: apply dart fix and format on codebase
755608f to
9e160ad
Compare
Author
|
Full disclosure this is my first OSS contribution ever, and feedback is greatly appreciated. |
Collaborator
|
Sorry but this isn't a priority right now. See details on #1293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Close #1311
Solution description
Added
allowClearproperty toFormBuilderDateTimePickeralso builds upon the default input decoration.To use the new property
Screenshots or Videos
As you can see the
xicon doesn't appear when the field is emptyThe
xicon appears ONLY when date and time are both selected, and also not selecting time leads to empty value in the fieldTo Do