-
Notifications
You must be signed in to change notification settings - Fork 0
Build/update deps #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/update deps #135
Conversation
- Update version in pubspec.yaml from 1.0.1 to 1.1.0
- Update bloc from 9.0.0 to 9.0.1 - Update go_router from 16.2.1 to 16.2.4 - Update google_fonts from 6.3.1 to 6.3.2 - Update share_plus from 11.1.0 to 12.0.0 - Update very_good_analysis from 9.0.0 to 10.0.0 - Remove ansicolor, csslib, flutter_native_splash, html, universal_io - Update version from 1.1.0 to 1.1.1
… from 10.0.0 to 12.0.0 - Remove flutter_native_splash dependency - Update very_good_analysis to ^10.0.0 - Update share_plus to ^12.0.0
- Update bloc from 9.0.0 to 9.0.1 - Update flutter_bloc from 9.1.0 to 9.1.1 - Update go_router from 16.0.0 to 16.2.4 - Update google_fonts from 6.2.1 to 6.3.2 - Update homepage and documentation URLs - Add funding link - Add screenshot to package metadata
- Remove `flutter_native_splash` dependency - Update `bloc`, `flutter_bloc`, `go_router`, `google_fonts`, `share_plus`, and `very_good_analysis` dependencies - Update `homepage` and `documentation` URLs in pubspec.yaml - Add `funding` link to pubspec.yaml - Add `flutter-news-app-full-sourcecode` topic to pubspec.yaml - Add `screenshots` configuration to pubspec.yaml
- Change the GitHub sponsors link in the pubspec.yaml file - Updated the link from 'flutter-news-app-full-source-code-toolkit' to 'flutter-news-app-full-source-code'
- Updated share_plus dependency in pubspec.yaml - Updated related entry in pubspec.lock - Adjusted topics in pubspec.yaml
- Revert share_plus dependency update from ^12.0.0 to ^11.1.0
- Deleted the entire flutter_launcher_icons.yaml file - Removed configurations for Android, web, and adaptive icons - This change simplifies the project structure and removes unnecessary files
- Add dark and light logo images for the Flutter News App - Update pubspec.yaml to include new logo assets - Remove old logo entry from screenshots section - Add descriptions for new logo assets in screenshots section
- Update Icon-192.png - Update Icon-512.png - Update Icon-maskable-192.png - Update Icon-maskable-512.png
- Replace launcher_icon.png for hdpi, mdpi, xhdpi, xxhdpi, and xxxhdpi densities
- Replace old favicon with new design
…ive_splash - Add flutter_native_splash dependency to pubspec.yaml - Configure native splash screen settings in pubspec.yaml - Update pubspec.lock with new dependencies - Adjust screenshots section in pubspec.yaml
…native_splash` configurations - Update `flutter_launcher_icons` configurations - Update `flutter_native_splash` configurations - Bump `bloc` to `^9.0.1` - Bump `flutter_bloc` to `^9.1.1` - Bump `go_router` to `^16.2.4` - Update version to 1.2.0
- Delete logo.png image file from assets/icon directory
- Replace static splash images with adaptive ones for both Android and web - Update splash screen HTML and CSS for web platform - Add support for dark mode on the splash screen - Improve splash screen removal logic
…ound - Remove unused assets directory - Add logo directory to assets - Remove adaptive_icon_background configuration for flutter_launcher_icons
- Replace dark and light logo images in assets folder - New logos likely improve visual identity and branding of the app
- Replace existing splash screen images with new versions for both light and dark themes - Update splash screen configuration in web/index.html - Images updated for different screen densities and device modes
- Update launcher icons for Android app in various densities - Update favicon and web app icons including Icon-192.png, Icon-512.png, Icon-maskable-192.png, and Icon-maskable-512.png
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive update of the project's dependencies to leverage the latest package versions and improve overall stability and performance. It also streamlines the configuration for app icons and splash screens by centralizing them and enhances the web experience with a more dynamic splash screen. Additionally, project metadata has been enriched to provide more detailed information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on updating dependencies and refactoring build configurations. My review identifies a few areas for improvement: a bug in the web splash screen removal logic that leaves a loader visible, a suggestion to add adaptive icon support for Android to enhance the user experience, and a minor correction for an inaccurate entry in the CHANGELOG.md
. The dependency updates and other refactorings are well-executed.
- Remove `flutter-news-app-full-sourcecode` from topics - Add `flutter` and `flutter-full-app` to topics
- Remove extra whitespace and newlines from the HTML file - Adjust indentation for better readability - Add missing closing tags for html and head elements - Format code inside style tags for better visibility - Add line breaks between HTML elements for clarity
Status
READY
Description
This pull request focuses on a comprehensive update of the project's dependencies to leverage the latest package versions and improve overall stability and performance. It also streamlines the configuration for app icons and splash screens by centralizing them and enhances the web experience with a more dynamic splash screen. Additionally, project metadata has been enriched to provide more detailed information.
Type of Change