Fix/web splash remover #136
Conversation
- Wrap removeSplashFromWeb() call in WidgetsBinding.instance.addPostFrameCallback - Ensures proper timing for splash screen removal after the app is ready - Improves consistency between web and other platforms
- Remove flutter_bootstrap_js script - Add event listener for window load event - Implement custom Flutter initialization logic - Improve code structure and readability
- Remove custom Flutter loading script
- Replace with {{ flutter_bootstrap_js }} placeholder
- Simplify HTML structure for better maintainability
- Update pubspec.yaml to include web: true in flutter_native_splash configuration - Ensures consistent configuration application across all supported platforms
…rapping - Add serviceWorkerVersion variable to index.html - Update app bootstrapping process to use flutter.js - Enhance loading process with entrypoint loading functionality - Remove unnecessary bootstrap script from body
- Updated CHANGELOG.md to reflect the fix for the web splash screen issue - Corrected the bootstrap script in index.html to ensure proper functionality
- Update version in pubspec.yaml from 1.2.0 to 1.2.1
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a significant bug affecting the web version of the application, where the splash screen would remain visible indefinitely. The fix involves a comprehensive update to the web's bootstrapping process in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively resolves an issue where the web splash screen was not being removed after the application loaded. The solution is well-rounded, involving an update to the web bootstrap script in index.html, correctly timing the splash screen removal in main.dart using addPostFrameCallback, and updating the project version and changelog. The changes align the project with current Flutter web best practices. I've included one suggestion to improve the long-term maintainability of the fix in index.html.
- Changed 'web' value from true to false in flutter_native_splash configuration - Ensures web platform is not affected by the flutter_native_splash settings
1 participant
Status
READY
Description
This pull request addresses a significant bug affecting the web version of the application, where the splash screen would remain visible indefinitely. The fix involves a comprehensive update to the web's bootstrapping process in index.html and a refinement of the splash screen removal timing within the Flutter application's main.dart. These changes ensure a seamless and correct loading experience for users accessing the application via a web browser.
Type of Change