Refactor/app shell #92
Conversation
…ose button - Add Arabic translations for "aboutIconTooltip" and "closeButtonText" in app_ar.arb - Add English translations for "aboutIconTooltip" and "closeButtonText" in app_en.arb - Include descriptions for new translations to provide context for translators
- Add app name at the top of the navigation rail - Implement UserNavigationRailFooter at the bottom of the navigation rail - Remove PopupMenuButton from app bar for user actions - Update imports to reflect changes
- Remove bottom PreferredSize widget - Add AboutIcon to actions - Simplify TabBar layout - Use padding from AppPadding medium instead of large
- Adjust indentation and line breaks for better readability - Remove unnecessary imports and code - Replace description in AppBar with AboutIcon for better UI/UX - Optimize TabBar placement and actions in AppBar
- Remove settings page description from AppBar - Add AboutIcon widget to AppBar actions - Import AboutIcon from shared widgets
- Create a new AboutIcon widget that displays information in a dialog - The widget takes dialogTitle and dialogDescription as parameters - It shows an info icon which, when pressed, displays an AlertDialog - The dialog includes a close button for dismissal
- Create a new widget for displaying user-specific actions in the navigation rail footer - Include settings and sign-out options - Implement localization support for labels - Add routing for settings page and logout functionality
- Add export for about_icon.dart - Add export for user_navigation_rail_footer.dart - Update export path for searchable_selection_input.dart
- Remove app bar and move dashboard title to navigation rail - Add UserNavigationRailFooter and align to bottom - Implement adaptive scaffolding for various screen sizes - Adjust layout for both extended and unextended navigation rail states
- Replace AppBar actions with a Row containing the title and AboutIcon - Add SizedBox for spacing between title and icon - This change allows for a more compact and centered app bar layout
… rail footer - Add AboutIcon to ContentManagementPage and SettingsPage app bars - Move user navigation rail footer content outside of Container widget - Adjust spacing and layout for app bar titles and icons
- Remove custom font style for page title - Increase spacing between title and icon
- Change SizedBox width from AppSpacing.xs to AppSpacing.sm
- Adjust spacing from AppSpacing.xs to AppSpacing.sm for better visual separation
- Add theme color for icon to match surface variant - Set icon size to 20 for better visibility - These changes improve the icon's appearance and consistency with the app's design guidelines
- Replace UserNavigationRailFooter with custom settings and sign-out tiles - Add expanded row for app name in extended state - Implement consistent styling for nav rail items - Add Bloc listener for app logout functionality - Update imports to include necessary packages and routes
- Deleted the entire UserNavigationRailFooter widget class - Removed all related imports and code
- Modify the condition for extending the navigator - Include small screen sizes in addition to medium-large sizes
- Removed unused export statement for 'user_navigation_rail_footer.dart' - This change simplifies the codebase by eliminating unused imports
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the application's user interface and overall code quality through strategic refactoring. The core Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily refactors the AppBar across several pages, introducing a new reusable AboutIcon widget to display page descriptions in a dialog. This is a nice improvement for UI consistency and cleanliness. The PR also includes a significant amount of code cleanup by removing unnecessary comments and improving formatting.
I've found a potential bug in the AppShell's responsive logic for the navigation rail and suggested a fix. I also pointed out an opportunity to reduce code duplication in the same file for better maintainability. Overall, this is a good refactoring with minor issues to address.
- Change column spacing from AppSpacing.md to AppSpacing.sm in the DataTable widget
- Add visualDensity and iconSize to Edit button for better appearance - Wrap PopupMenuButton in SizedBox to adjust width and prevent layout overflow - Reduce iconSize of overflow button for consistency with Edit button
- Change padding from all sides to only top - Update applied for headlines_page.dart, sources_page.dart, and topics_page.dart - Adjust padding value from AppSpacing.lg to AppSpacing.sm
- Change SizedBox width from AppSpacing.sm to AppSpacing.xs in multiple files: - app_configuration_page.dart - content_management_page.dart - settings_page.dart
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change