Skip to content

Conversation

@ONLYstcm
Copy link
Contributor

  • Added onCancelCallback to allow complete replacement of the default behavior of AdaptiveSnackBar when an LlmCancelException occurs.
  • Added onFailureCallback to enable overriding the default behavior of AdaptiveAlertDialog for LlmFailureException and general LlmException.
  • Added cancelMessage to allow CANCEL message to be changed when an LlmCancelException occurs.
  • Added errorMessage to allow ERRORz message to be changed when an LlmCancelException` occurs.

Implements: #37

@google-cla
Copy link

google-cla bot commented Dec 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@csells
Copy link
Contributor

csells commented Dec 26, 2024

@ONLYstcm please include a new sample that shows off this capability.

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ONLYstcm Please sign the CLA. We can't merge the PR without it

@ONLYstcm
Copy link
Contributor Author

@csells @domesticmouse Please take a look now 🙏

@domesticmouse domesticmouse dismissed their stale review December 28, 2024 20:16

CLA now signed

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @csells

@csells
Copy link
Contributor

csells commented Jan 27, 2025

@ONLYstcm lgtm. only needs updates to the CHANGELOG.

Copy link
Contributor

@csells csells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to do this, but can we look at adding some test coverage here?

The upside of having test coverage is that we won't break this functionality with future changes as this functionality will be checked by our friend the GitHub CI bot.

Thanks!

@domesticmouse
Copy link
Contributor

Btw, update your PR to fix the beta CI issue. It was fixed in #51

@domesticmouse
Copy link
Contributor

Landing as is

@domesticmouse domesticmouse merged commit 42248d4 into flutter:main Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants