-
Notifications
You must be signed in to change notification settings - Fork 73
Add onCancelCallback, onFailureCallback in LLM Chat View #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@ONLYstcm please include a new sample that shows off this capability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ONLYstcm Please sign the CLA. We can't merge the PR without it
|
@csells @domesticmouse Please take a look now 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL @csells
|
@ONLYstcm lgtm. only needs updates to the CHANGELOG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to do this, but can we look at adding some test coverage here?
The upside of having test coverage is that we won't break this functionality with future changes as this functionality will be checked by our friend the GitHub CI bot.
Thanks!
|
Btw, update your PR to fix the |
|
Landing as is |
onCancelCallbackto allow complete replacement of the default behavior ofAdaptiveSnackBarwhen anLlmCancelExceptionoccurs.onFailureCallbackto enable overriding the default behavior ofAdaptiveAlertDialogforLlmFailureExceptionand generalLlmException.cancelMessageto allowCANCELmessage to be changed when anLlmCancelExceptionoccurs.errorMessageto allowERRORz message to be changed when anLlmCancelException` occurs.Implements: #37