Skip to content

Conversation

AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Sep 16, 2025

fixes #175355

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review September 16, 2025 09:33
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AbdeMohlbi thanks for the contribution! Can you take a look at the failure here? It looks like it is just a matter of running the formatter to resolve. Thanks!

@AbdeMohlbi
Copy link
Contributor Author

@Piinks i'm not sure if this is expected but it seems that the file is correctly formated according to dart format . on master maybe because it is using an old sdk version ,still i tried according to what the failure is saying and did dart pub global activate flutter_plugin_tools && dart pub global run flutter_plugin_tools format but it did not change anything so i applied the given diff not sure if this is a bug or what .

@AbdeMohlbi AbdeMohlbi requested a review from Piinks September 18, 2025 17:10
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for fixing the formatting!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025
Copy link

auto-submit bot commented Sep 23, 2025

autosubmit label was removed for flutter/assets-for-api-docs/259, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025
@Piinks Piinks merged commit bc4bb28 into flutter:main Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate radio list tile example in assets-for-api docs
2 participants