implemented har feature #7970

hrajwade96 · 2024-06-23T07:58:11Z

Export har feature added.
includes serialisation and de-serialisation (from and to har).
test cases added.

This PR addresses below issue -
#3806

Please add a note to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read the Flutter Style Guide recently, and have followed its advice.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or there is a reason for not adding tests.

If you need help, consider asking for help on Discord.

hrajwade96 · 2024-06-23T12:48:23Z

@kenzieschmoll @exaby73
When I disconnect the app loader keeps showing #7968

bkonyi

Thanks for the contribution! I've got mostly minor comments so far.

packages/devtools_app/lib/src/screens/network/network_controller.dart

packages/devtools_app/lib/src/shared/analytics/constants/_network_constants.dart

packages/devtools_app/lib/src/screens/network/network_controller.dart

bkonyi

Thanks for addressing the comments!

packages/devtools_app/lib/src/screens/network/har_builder.dart

bkonyi · 2024-06-26T15:17:19Z

packages/devtools_app/lib/src/screens/network/har_builder.dart

+    };
+  }).toList();
+
+// Assemble the final HAR object


Ubernit: indent

sorry didn't get you

packages/devtools_app/lib/src/screens/network/har_builder.dart

packages/devtools_app/lib/src/shared/analytics/constants/_network_constants.dart

bkonyi · 2024-06-26T15:19:36Z

packages/devtools_app/lib/src/shared/analytics/constants/_network_constants.dart

+  static const onContentLoad = -1;
+  static const onLoad = -1;
+  static const httpVersion = 'HTTP/1.1';
+  static const responseHttpVersion = 'http/2.0';


Should this be hardcoded?

this field doesn't seem to be available in the 'DartIOHttpRequestData'

Can we put some placeholder like "Unknown" instead? Maybe @brianquinlan knows if this information is available somewhere.

…har_feature

kenzieschmoll · 2024-07-03T20:19:40Z

When I disconnect the app loader keeps showing #7968

This issue should be resolved if you merge with the master branch. Fix was here: #7992

hrajwade96 · 2024-07-06T08:22:25Z

@kenzieschmoll as I observed the offline functionality works in these ways :

When the app gets disconnected, view offline data.
Before connecting to the app, few screens support importing a file.
While the app is connected user can still import a saved file, it disconnects the app and in goes in offline mode where dev can view the data.

I have implemented the 1st one (changes yet to be pushed as of now).
Can you clarify which of these is req for network screen?
this is my demo pr for 1st point from my forked repo - hrajwade96#1
let me know your inputs

hrajwade96 · 2024-07-06T08:33:08Z

@bkonyi can you re-check the comments and mark them as resolved if they are addressed

bkonyi · 2024-07-08T13:26:17Z

@bkonyi can you re-check the comments and mark them as resolved if they are addressed

Sorry for the delay, I'll take a look.

bkonyi · 2024-07-08T13:40:02Z

All of my comments are basically addressed and this LGTM overall. I'll let @kenzieschmoll give final say on the PR. Thanks for your contribution!

hrajwade96 · 2024-07-08T16:16:01Z

All of my comments are basically addressed and this LGTM overall. I'll let @kenzieschmoll give final say on the PR. Thanks for your contribution!

Looking forward to contributing more in future, after this one is done!

kenzieschmoll

I apologize, I had a pending review that I never hit submit on. Here are my recommendations.

packages/devtools_app/lib/src/screens/network/har_builder.dart

packages/devtools_app/lib/src/screens/network/network_controller.dart

packages/devtools_app/lib/src/shared/analytics/constants/_network_constants.dart

packages/devtools_app/lib/src/screens/network/network_screen.dart

packages/devtools_app/lib/src/shared/analytics/constants/_network_constants.dart

packages/devtools_app/lib/src/screens/network/har_network_data.dart

packages/devtools_app/lib/src/screens/network/har_data_entry.dart

packages/devtools_app/lib/src/shared/http/http_request_data.dart

packages/devtools_app/lib/src/screens/network/har_data_entry.dart

kenzieschmoll

LGTM once all tests pass. Thanks for the feature!

hrajwade96 · 2024-07-26T18:16:12Z

LGTM once all tests pass. Thanks for the feature!

Thank you for the review! I'll ensure all tests pass. Appreciate the feedback and support!

…har_feature

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart

hrajwade96 · 2024-07-30T02:18:04Z

LGTM once all tests pass. Thanks for the feature!

@kenzieschmoll All the tests have passed can this be merged now? Or Anything else remaining?

implemented har feature

da7252d

hrajwade96 requested review from a team, bkonyi and kenzieschmoll as code owners June 23, 2024 07:58

reverting some code

f6f9491

hrajwade96 mentioned this pull request Jun 23, 2024

Export Network Tab as HAR file #3806

Closed

bkonyi reviewed Jun 24, 2024

View reviewed changes

hrajwade96 added 4 commits June 24, 2024 22:17

comments resolved, code refactoring

a1ba9bd

added doc comments for buildHar

ef3a637

exportController moved to method scope

058e053

httpRequests moved to NetworkController class

ae292ad

hrajwade96 requested a review from bkonyi June 24, 2024 17:32

Merge branch 'master' into export_har_feature

9d5231b

bkonyi reviewed Jun 26, 2024

View reviewed changes

hrajwade96 added 5 commits June 26, 2024 21:49

code comments resolved

1b9e483

Merge remote-tracking branch 'origin/export_har_feature' into export_…

0e5cdbb

…har_feature

removed pages, pageref and serverIPAddress

5c306c1

added header size and body size, creatorVersion set

5d8fc75

organized imports

16faad7

hrajwade96 requested a review from bkonyi June 27, 2024 08:14

Merge remote-tracking branch 'upstream/master' into export_har_feature

f843862

kenzieschmoll reviewed Jul 8, 2024

View reviewed changes

removed mixin and override, changed year to 2024, renamed variable

1c4442c

added type to list

e1c9791

hrajwade96 requested a review from kenzieschmoll July 19, 2024 17:59

kenzieschmoll reviewed Jul 19, 2024

View reviewed changes

hrajwade96 added 4 commits July 20, 2024 09:40

used values directly, removed unnecessary null checks

c0cb621

used values directly, fixed typo

daccfde

restructured har creation, implemented toJson

2692ea1

used values from constants

01f5122

hrajwade96 requested a review from kenzieschmoll July 20, 2024 05:25

kenzieschmoll reviewed Jul 23, 2024

View reviewed changes

hrajwade96 added 2 commits July 25, 2024 16:48

changed dynamic to Object?, dart docs fix, added header

c5c1842

added comments for explanation

2734fcb

hrajwade96 requested a review from kenzieschmoll July 25, 2024 12:09

hrajwade96 added 2 commits July 26, 2024 10:05

minor fixes

fb10b26

added tests for HarDataEntry

8a65da8

kenzieschmoll reviewed Jul 26, 2024

View reviewed changes

packages/devtools_app/lib/src/screens/network/har_data_entry.dart Outdated Show resolved Hide resolved

kenzieschmoll approved these changes Jul 26, 2024

View reviewed changes

hrajwade96 and others added 2 commits July 26, 2024 23:43

code reformatted, updated release notes

6443964

Merge branch 'master' into export_har_feature

89dae77

hrajwade96 requested a review from kenzieschmoll July 26, 2024 18:16

hrajwade96 added 2 commits July 27, 2024 10:18

minor change

b26b833

Merge remote-tracking branch 'origin/export_har_feature' into export_…

6d4177b

…har_feature

kenzieschmoll reviewed Jul 29, 2024

View reviewed changes

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart Outdated Show resolved Hide resolved

reverting change

83b4a3f

hrajwade96 requested a review from kenzieschmoll July 29, 2024 17:38

added missing trailing comma

7d211fd

kenzieschmoll approved these changes Jul 29, 2024

View reviewed changes

kenzieschmoll merged commit fae408a into flutter:master Jul 30, 2024

hrajwade96 mentioned this pull request Aug 4, 2024

Enable offline support for all DevTools screens #4470

Open

9 tasks

implemented har feature #7970

implemented har feature #7970

Uh oh!

Conversation

hrajwade96 commented Jun 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hrajwade96 commented Jun 23, 2024

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkonyi Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

hrajwade96 Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bkonyi Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

hrajwade96 Jun 27, 2024

Choose a reason for hiding this comment

Uh oh!

bkonyi Jul 8, 2024

Choose a reason for hiding this comment

Uh oh!

kenzieschmoll commented Jul 3, 2024

Uh oh!

hrajwade96 commented Jul 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hrajwade96 commented Jul 6, 2024

Uh oh!

bkonyi commented Jul 8, 2024

Uh oh!

bkonyi commented Jul 8, 2024

Uh oh!

hrajwade96 commented Jul 8, 2024

Uh oh!

kenzieschmoll left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hrajwade96 commented Jun 23, 2024 •

edited

Loading

hrajwade96 commented Jul 6, 2024 •

edited

Loading