[CPU Profiler] Delete the "Profile app start up" button #9358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu16
force-pushed
the
deprecate-profile-app-start-up-button
branch
2 times, most recently
from
14b1165 to
6122206
Compare
derekxu16
requested review from
kenzieschmoll,
bkonyi and
a team
as code owners
elliette
reviewed
Aug 1, 2025
| @@ -111,15 +111,15 @@ class _SecondaryControls extends StatelessWidget { | |||
| icon: Icons.timer, | |||
| label: 'Profile app start up', | |||
| tooltip: | |||
| 'Load all Dart CPU samples that occurred before \n' | |||
| 'the first Flutter frame was drawn (if available)', | |||
| 'This button is deprecated. The new procedure for profiling an' | |||
There was a problem hiding this comment.
Instead of deprecating the button, I think it would be better to remove it entirely (and update the website docs on CPU profiling to call out this flag)
There was a problem hiding this comment.
Sounds good. I've updated this PR, and opened flutter/website#12272 to update the website.
derekxu16
force-pushed
the
deprecate-profile-app-start-up-button
branch
from
6122206 to
1974038
Compare
derekxu16
changed the title
bkonyi
approved these changes
Aug 6, 2025
hrajwade96
pushed a commit
to hrajwade96/devtools
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context: the VM team has learned that the implementation of CPU sample streaming in the VM can sometimes cause it to crash. We have concluded that the best way to proceed is by removing support for CPU sample streaming from the VM. Removing support for CPU sample streaming will mean that DevTools will no longer be able to use that support for its "Profile app start up" feature. We discussed this with @kenzieschmoll, and she approved of the plan to have users pass the
--profile-startupDart CLI flag or Flutter CLI flag instead when they want to see startup CPU samples.