-
Notifications
You must be signed in to change notification settings - Fork 36
docs: updated README.md with graphics and sample example #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: updated README.md with graphics and sample example #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the README.md
by adding visuals and examples, which is a great way to showcase the project's capabilities. I've made a few suggestions to correct some minor grammatical errors and improve the readability of the new text. Overall, these are valuable additions to the documentation.
via Gemini Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
via Gemini Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
via Gemini Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
via Gemini Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hamza! Thank you so much for this PR! I'm sorry to nit pick but I'm eager to keep the README relatively polished because it's the first thing that people see.
misc/travel_app_genui_example.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could you update the blue text to 'The LLM generated this interactive UI by composing widgets in the app's "Catalog"'?
Overall this graph is awesome!
README.md
Outdated
@@ -81,6 +81,23 @@ Widget build(BuildContext context) { | |||
} | |||
``` | |||
|
|||
## Look & Feel | |||
Here's how it works in practice, but please be advised it's labelled as "Highly Experimental". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to state this again because it's written elsewhere.
README.md
Outdated
*The GIF above shows how GenUI enables dynamic, interactive UI generation — instead of text descriptions or code from a traditional AI coding agent.* | ||
|
||
### Core Difference | ||
This UI is not generated in the form of code; rather, it's generated at runtime based on a widget catalog from the developers' project (application catalog) combined with the genui catalog (standard catalog). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this just be:
"This UI is not generated in the form of code; rather, it's generated at runtime based on a widget catalog from the developers' project"
We're not sure yet whether we should focus on providing a standard catalog or let developers choose all the widgets, so don't want to emphasize this yet.
README.md
Outdated
|
||
<img src="misc/travel_app_genui_example.png" alt="GenUI Features Breakdown" height="600"> | ||
|
||
*This screenshot highlights the core implementation of traditional LLM-based UI vs. GenUI-based UI.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this explanatory text
…thub.com/mhmzdev/genui into docs/added-graphics-for-visuals-of-genui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!!
Description
Pre-launch Checklist
///
).Results
Added a .gif and .png graphics: