Add checkout experience for hotels. #304
Conversation
There was a problem hiding this comment.
It might make sense to try to generate all these images at the same aspect ratio, probably 1:1 so that they look good and consistent in a carousel.
There was a problem hiding this comment.
Yes! Will do in next PR.
| @@ -0,0 +1,27 @@ | |||
| # Hotel Image Generation Prompts | |||
There was a problem hiding this comment.
This is awesome! Were you able to try Seth's script out? It'd be amazing to check it in and generate more like ~10 hotel images.
There was a problem hiding this comment.
Can you point me to the script, please?
There was a problem hiding this comment.
Behold! https://github.com/sethladd/testforcraig/tree/main/scripts
look for generate_image.js , generate_all_images.sh
it's a node.js script, because there was no vanilla dart library that worked with imagen
| } | ||
|
|
||
| /// Synchronous version for example data generation. | ||
| HotelSearchResult listHotelsSync(HotelSearch search) { |
There was a problem hiding this comment.
Would be great to expand this to more like 10-15 hotels to judge the performance and reliability impact there. We can make it return only a few results each request at the start. But later we should find a way to make large result sets performant.
There was a problem hiding this comment.
Yes, it may. Let's plan and prioritize it as a separate task. And, it may be a good task for someone who is entering the team.
| 'query': S.string( | ||
| description: 'The search query, e.g., "hotels in Paris".', | ||
| ), | ||
| 'checkIn': S.string( |
There was a problem hiding this comment.
Side comment: I'm worried dealing with real dates makes this hard to test, because it's annoying to constantly pick dates for a fake holiday. I wonder if we can streamline this by instructing the LLM to prepopulate search chips with random valid dates (e.g. inject some date a couple of weeks from now in the prompt) to make it easy to demo. Sort of like how Airbnb will do that for you.
There was a problem hiding this comment.
I am not sure I understand your comment. Can you elaborate? Do you mean manual testing or test coverage? Do you suggest to update this comment to instruct LLM to suggest dates? Or you suggest to update main prompt in the app to do it? Or something else?
There was a problem hiding this comment.
Love this improvement. Can we also update this to support displaying more information below e.g. hotel summaries, prices etc? I think that will make it feel much more realistic.
There was a problem hiding this comment.
Yes, let's outline it as separate task and prioritize. Added to standup meeting discussion.
Fixes #134
In gallery:
Screen.Recording.2025-09-13.at.5.55.03.PM.mov
In 'real' flow:
Screen.Recording.2025-09-14.at.1.29.21.PM.mov