Hotel details. #318
Merged
Hotel details. #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d533f0.
jacobsimionato
approved these changes
Sep 17, 2025
| @@ -17,7 +20,13 @@ final _schema = S.object( | |||
| description: 'A list of items to display in the carousel.', | |||
| items: S.object( | |||
| properties: { | |||
| 'title': S.string(description: 'The title of the carousel item.'), | |||
| 'description': S.string( | |||
There was a problem hiding this comment.
Optional: How about having a separate subtitle field or something which is shown in a different color, like a grey or something? While it's a small thing, I think it makes the UI look quite a bit more polished to have visually separated sections like that.
There was a problem hiding this comment.
I am afraid it may make it more complicated for AI. So, we may loose reliability.
I like the idea. But I would make it P2 and test it carefully. BTW, can be a good item for external contributors.
|
Merged in spite of the error as it seems main is broken: #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309