Skip to content

Conversation

AbdeMohlbi
Copy link
Contributor

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@AbdeMohlbi
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Java and Kotlin compatibility versions from 11 to 17 across numerous build.gradle files in the repository. This is a significant and widespread change to modernize the Android build configuration. The changes also include updates to related documentation, tooling, and tests to reflect the new Java version. My review confirms that the changes are largely consistent, but I've identified a couple of minor areas for improvement to ensure complete consistency across the codebase.


kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've correctly updated jvmTarget, this build.gradle file is missing the compileOptions block to set sourceCompatibility and targetCompatibility to Java 17. For consistency with the other files in this PR, please add it. For example:

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_17
        targetCompatibility JavaVersion.VERSION_17
    }

Comment on lines +376 to +377
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've updated this part of the error message to suggest Java 17, the alternative suggestion for toolchain on line 384 still refers to Java 11. To be consistent with the goal of this PR, please update it to Java 17 as well.

languageVersion = JavaLanguageVersion.of(17)

@AbdeMohlbi AbdeMohlbi closed this by deleting the head repository Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant