-
Couldn't load subscription status.
- Fork 3.5k
[many} Update all examples apps to use java 17 complile options #10195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ android { | |
| } | ||
|
|
||
| kotlinOptions { | ||
| jvmTarget = '11' | ||
| jvmTarget = JavaVersion.VERSION_17.toString() | ||
| } | ||
|
Comment on lines
33
to
35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is missing the compileOptions {
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
} |
||
|
|
||
| defaultConfig { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think the README change technically requires a version bump, but it looks like this change won't affect clients anyways. So I'm fine with not needing to publish this change.