Skip to content

Conversation

nilsreichardt
Copy link
Contributor

All the doc comments referred to the allowDrawingOutsideOfViewBox parameter. However, there is no allowDrawingOutsideOfViewBox parameter. The parameter is called allowDrawingOutsideViewBox (without a "Of"). This PR fixes this issue.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in doc comments for the allowDrawingOutsideViewBox parameter in lib/svg.dart. The package version is also bumped to 2.2.2 and the CHANGELOG.md is updated accordingly. The changes are correct and improve documentation accuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants