[go_router_builder]: Fix Parameter generates a warning #8889

CaoGiaHieu-dev · 2025-03-19T02:07:26Z

Fix: flutter/flutter#164621

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

Co-authored-by: chunhtai <[email protected]>

chunhtai

LGTM

packages/go_router_builder/CHANGELOG.md

chunhtai

LGTM

hannah-hyj

LGTM, thanks!

Co-authored-by: chunhtai <[email protected]>

CaoGiaHieu-dev · 2025-07-07T06:00:09Z

@Piinks
cc @chunhtai
Hi . sorry for late reply .

There is only one error CI When bumping the version for release, the NEXT section should be incorporated into the new version's release notes. . The NEXT section is Restricts `build` to versions less than 2.5.0. which out scoped of my pr .

Piinks · 2025-07-08T17:45:33Z

packages/go_router_builder/CHANGELOG.md


 - Restricts `build` to versions less than 2.5.0.

+## 3.0.2


I don't think it is possible to avoid the above in Next because that code is already landed and present. I think the path forward here is to include it as a bullet point under 3.0.2 and remove Next.

it was related to this issue flutter/flutter#170832 . it wasnt landed yet .

BTW if my pr cannot merge so i will check again after it fixed

justinmc · 2025-07-21T18:12:36Z

There's a failure that can probably be fixed with a merge/rebase.

justinmc · 2025-07-22T22:23:50Z

@CaoGiaHieu-dev Heads up that there is another failure.

CaoGiaHieu-dev · 2025-07-23T01:05:45Z

@CaoGiaHieu-dev Heads up that there is another failure.

@justinmc Hi , thanks for your time. it because this issue flutter/flutter#170832 wasnt landed yet .

I already comment about this cicd fail #8889 (comment)

* main: (56 commits) [go_router_builder] Support extension types (flutter#9458) Roll Flutter from e2a347b14a18 to 34c2a3b158b2 (41 revisions) (flutter#9803) [go_router_builder] Migrate to Element2 API and update dependencies (flutter#9649) [in_app_purchase_storekit] Add support for quantity in consumable product purchases (#171570) (flutter#9698) [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter#9756) Roll Flutter from 1590543f6794 to e2a347b14a18 (1 revision) (flutter#9784) [camera_avfoundation] Implementation swift migration - part 11 (flutter#9690) [camera_avfoundation] Fix crash when streaming while recording (flutter#9691) Roll Flutter from 38217906e95c to 1590543f6794 (14 revisions) (flutter#9780) Roll Flutter from 92a6bfbfd6ef to 38217906e95c (17 revisions) (flutter#9778) [video_player] Improve KVO handling on iOS (flutter#9718) [dependabot]: Bump the test-dependencies group across 15 directories with 7 updates (flutter#9736) Roll Flutter from 9de63a03428f to 92a6bfbfd6ef (11 revisions) (flutter#9769) [google_maps_flutter_platform_interface] Add Advanced markers support (flutter#9737) [camera_android_camerax] Re-land "Force new Surface for each SurfaceRequest" (flutter#9760) [google_maps_flutter] Add ability to perform Google Maps SDK warmup (flutter#9674) Roll Flutter from 59fc766c6fdf to 9de63a03428f (6 revisions) (flutter#9764) [webview_flutter_wkwebview] Extended Web View API on iOS to add flexibility when working with local HTML content (flutter#8787) [local_auth] Differentiate iOS authentication errors (flutter#9705) manual roll to 59fc766c6fdfd03d0983fc95ce8b76793a300dd5 (flutter#9758) ... # Conflicts: # packages/go_router_builder/lib/src/type_helpers.dart # packages/go_router_builder/pubspec.yaml

justinmc · 2025-08-19T22:19:02Z

@CaoGiaHieu-dev Thanks for fixing the failures, but now there are some merge conflicts.

vware · 2025-08-22T07:47:01Z

@Piinks can we please get this merged now? :)

…tter/packages#8889)

flutter/packages@1ef712e...86fbeec 2025-08-27 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.ext:truth from 1.6.0 to 1.7.0 in /packages/espresso/android (flutter/packages#9884) 2025-08-27 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.4.0-android to 33.4.8-android in /packages/camera/camera_android_camerax/android (flutter/packages#9883) 2025-08-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 19 directories with 2 updates (flutter/packages#9854) 2025-08-26 [email protected] [go_router_builder]: Fix Parameter generates a warning (flutter/packages#8889) 2025-08-26 [email protected] Roll Flutter from a4cb00a to c65f01d (28 revisions) (flutter/packages#9894) 2025-08-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 11 directories with 4 updates (flutter/packages#9880) 2025-08-26 [email protected] Roll Flutter (stable) from 20f8274 to 05db968 (15 revisions) (flutter/packages#9892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#174521) flutter/packages@1ef712e...86fbeec 2025-08-27 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.ext:truth from 1.6.0 to 1.7.0 in /packages/espresso/android (flutter/packages#9884) 2025-08-27 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.4.0-android to 33.4.8-android in /packages/camera/camera_android_camerax/android (flutter/packages#9883) 2025-08-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 19 directories with 2 updates (flutter/packages#9854) 2025-08-26 [email protected] [go_router_builder]: Fix Parameter generates a warning (flutter/packages#8889) 2025-08-26 [email protected] Roll Flutter from a4cb00a to c65f01d (28 revisions) (flutter/packages#9894) 2025-08-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 11 directories with 4 updates (flutter/packages#9880) 2025-08-26 [email protected] Roll Flutter (stable) from 20f8274 to 05db968 (15 revisions) (flutter/packages#9892) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

CaoGiaHieu-dev and others added 17 commits February 28, 2025 10:05

allow parse Enum with nullable String

083973d

bump and update change log

b50c1b2

reformat

454b269

reformat

456d6c1

Merge branch 'main' into main

ba31e42

update

4fdc26a

update

13bdc00

update test

6281ddd

update

d220bd8

fix suffix

31ae729

Merge branch 'main' into main

5cb1f71

Merge branch 'main' into main

877c5fb

Update CHANGELOG.md

24f5301

Co-authored-by: chunhtai <[email protected]>

Merge branch 'main' into main

11338d8

Merge branch 'main' into main

6b23b9d

Merge branch 'flutter:main' into main

c59d3e9

fix warning

e9180dc

CaoGiaHieu-dev requested a review from chunhtai as a code owner March 19, 2025 02:07

github-actions bot added the p: go_router_builder label Mar 19, 2025

CaoGiaHieu-dev added 4 commits March 19, 2025 09:29

fix

aad960c

fix

c9dcab4

fix gen lints

fb94d91

update

689c8cb

CaoGiaHieu-dev changed the title ~~[go_router_builder]: Fix Typed route parameter generates a warning~~ [go_router_builder]: Fix Parameter generates a warning Mar 19, 2025

update change log

eaf2023

chunhtai approved these changes Mar 19, 2025

View reviewed changes

packages/go_router_builder/CHANGELOG.md Outdated Show resolved Hide resolved

chunhtai approved these changes Mar 19, 2025

View reviewed changes

chunhtai requested a review from hannah-hyj March 19, 2025 18:13

hannah-hyj approved these changes Mar 19, 2025

View reviewed changes

Update CHANGELOG.md

1461d76

Co-authored-by: chunhtai <[email protected]>

CaoGiaHieu-dev added 5 commits July 7, 2025 12:24

update

4b79fe6

update

992a897

bump

d0bbc51

update

c0fb4cb

update

e7222c4

CaoGiaHieu-dev force-pushed the main branch 2 times, most recently from aa5d404 to e7222c4 Compare July 7, 2025 06:26

Piinks reviewed Jul 8, 2025

View reviewed changes

Merge branch 'main' into main

d7ffa9e

Merge branch 'main' into main

6b77867

CaoGiaHieu-dev and others added 5 commits August 14, 2025 08:44

Merge branch 'main' into main

8b41333

Merge branch 'main' into main

2f59d48

fix

6feaa64

Merge branch 'main' into main

46923f3

Merge branch 'main' into main

b6942a8

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2025

auto-submit bot merged commit e60bb8f into flutter:main Aug 26, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2025

e60bb8fa1 [go_router_builder]: Fix Parameter generates a warning (flu…

0621a0a

…tter/packages#8889)

engine-flutter-autoroll mentioned this pull request Aug 27, 2025

Roll Packages from 1ef712e00013 to 86fbeecb7b4f (7 revisions) flutter/flutter#174521

Merged

[go_router_builder]: Fix Parameter generates a warning #8889

[go_router_builder]: Fix Parameter generates a warning #8889

Uh oh!

Conversation

CaoGiaHieu-dev commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

CaoGiaHieu-dev commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

CaoGiaHieu-dev Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc commented Jul 21, 2025

Uh oh!

justinmc commented Jul 22, 2025

Uh oh!

CaoGiaHieu-dev commented Jul 23, 2025

Uh oh!

justinmc commented Aug 19, 2025

Uh oh!

vware commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CaoGiaHieu-dev commented Mar 19, 2025 •

edited

Loading

CaoGiaHieu-dev commented Jul 7, 2025 •

edited

Loading