Skip to content

Conversation

@hashemim66110
Copy link

@hashemim66110 hashemim66110 commented Apr 15, 2025

change pushReplacementNamed type from void to Future<T?> and added returnValue to pushReplacementNamed method.

i was making a program and i need to pushReplacementNamed in a part of it. i checked the Documentation and it says the method pushReplacementNamed is returning a value. but when i tried to use it by context extensions it didn't return a value and got an error saying this method is void and doesn't return a value. so i simply updated method to return a value.

i didn't found any related open issue in issue board.

If you need help, consider asking for advice on the @HajMorty pv on [Telegram].

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

change pushReplacementNamed type from void to Future<T?>
and added returnValue to pushReplacementNamed method.
@hashemim66110 hashemim66110 requested a review from chunhtai as a code owner April 15, 2025 11:12
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@google-cla
Copy link

google-cla bot commented Apr 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hashemim66110 hashemim66110 changed the title Update extensions.dart Update go_router/lib/src/misc/extensions.dart Apr 15, 2025
@stuartmorgan-g
Copy link
Collaborator

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft April 15, 2025 13:44
@stuartmorgan-g stuartmorgan-g removed the request for review from chunhtai April 15, 2025 13:44
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hashemim66110 in order to merge this can you write a test and bump package version and change log?

@Piinks
Copy link
Contributor

Piinks commented Jul 8, 2025

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to re-open or submit a new PR if you have the time to address the review comments. Thanks!

@Piinks Piinks closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants