-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[google_maps_flutter] Fix iOS analysis for newer Xcode #9415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter] Fix iOS analysis for newer Xcode #9415
Conversation
Fixes analysis failures that fail CI in newer versions of the toolchain. Currently these are surfaced in the Xcode UI, but not the command-line analysis run done in CI. This unblocks future CI updates. Fixes flutter/flutter#170354
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
||
/// Creates a UIImage from Pigeon bitmap. | ||
UIImage *FGMIconFromBitmap(FGMPlatformBitmap *platformBitmap, | ||
UIImage * _Nullable FGMIconFromBitmap(FGMPlatformBitmap *platformBitmap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the callers and they can handle nil
. I think this was just an accident (on my part) because of the ASSUME macro.
test-exempt: unblocks adopting toolchain that will automatically enforce this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autosubmit label was removed for flutter/packages/9415, because - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/packages/9415, because - The status or check suite Linux_android_legacy android_platform_tests_legacy_api_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@974f152...0b322a2 2025-06-11 [email protected] Roll Flutter master to 2d9977c (flutter/packages#9402) 2025-06-11 [email protected] [google_maps_flutter] Fix iOS analysis for newer Xcode (flutter/packages#9415) 2025-06-10 [email protected] [in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 (flutter/packages#9280) 2025-06-10 [email protected] Roll Flutter master to 7e30df2 (flutter/packages#9413) 2025-06-10 [email protected] [vector_graphics]Add Null Check for Image Retrieval in listener.dart's onDrawImage Function (flutter/packages#9211) 2025-06-10 [email protected] Roll Flutter master to 8b22f67 (flutter/packages#9407) 2025-06-06 [email protected] Roll Flutter master to d8baa77 (flutter/packages#9379) 2025-06-06 [email protected] Fix the `zIndex`-related issue in the `copyWith` method. (flutter/packages#9396) 2025-06-06 [email protected] [multi] Remove @tool from docs that does not work (flutter/packages#9394) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes analysis failures that fail CI in newer versions of the toolchain. Currently these are surfaced in the Xcode UI, but not the command-line analysis run done in CI. This unblocks future CI updates. Fixes flutter/flutter#170354 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…r#170462) flutter/packages@974f152...0b322a2 2025-06-11 [email protected] Roll Flutter master to 2d9977c (flutter/packages#9402) 2025-06-11 [email protected] [google_maps_flutter] Fix iOS analysis for newer Xcode (flutter/packages#9415) 2025-06-10 [email protected] [in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 (flutter/packages#9280) 2025-06-10 [email protected] Roll Flutter master to 7e30df2 (flutter/packages#9413) 2025-06-10 [email protected] [vector_graphics]Add Null Check for Image Retrieval in listener.dart's onDrawImage Function (flutter/packages#9211) 2025-06-10 [email protected] Roll Flutter master to 8b22f67 (flutter/packages#9407) 2025-06-06 [email protected] Roll Flutter master to d8baa77 (flutter/packages#9379) 2025-06-06 [email protected] Fix the `zIndex`-related issue in the `copyWith` method. (flutter/packages#9396) 2025-06-06 [email protected] [multi] Remove @tool from docs that does not work (flutter/packages#9394) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes analysis failures that fail CI in newer versions of the toolchain. Currently these are surfaced in the Xcode UI, but not the command-line analysis run done in CI.
This unblocks future CI updates.
Fixes flutter/flutter#170354
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3