[interactive_media_ads] Adds support for time offsets of ad breaks #9953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
bparrishMines
changed the title
stuartmorgan-g
approved these changes
Sep 24, 2025
| -> [Double] | ||
| { | ||
| return pigeonInstance.adCuePoints.map { cuePoint -> Double in | ||
| return (cuePoint as! NSNumber).doubleValue |
There was a problem hiding this comment.
Is there an easy way for us to file an issue about the fact that this array should be an NSArray<NSNumber*> instead of an NSArray?
(Not to block this PR, of course, it's just weird that this is handled via documentation rather than the actual type system.)
There was a problem hiding this comment.
I will reach out to the team. I also need to followup on the issue with ui elements on iOS: https://github.com/flutter/packages/blob/main/packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdProxyAPIDelegate.swift#L41
bparrishMines
added
the
autosubmit
|
autosubmit label was removed for flutter/packages/9953, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
auto-submit
bot
removed
the
autosubmit
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2025
flutter/packages@117bf63...389c678 2025-09-25 [email protected] Update local_auth_darwin CODEOWNERS (flutter/packages#10074) 2025-09-25 [email protected] [interactive_media_ads] Adds support for time offsets of ad breaks (flutter/packages#9953) 2025-09-25 [email protected] Roll Flutter from 4a04204 to b1a28bc (44 revisions) (flutter/packages#10077) 2025-09-24 [email protected] [google_fonts] Make a map keyed on FontWeight non-const (flutter/packages#10058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#174405
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3